NE-2520: Promote GatewayAPIWithoutOLM to GA#2772
NE-2520: Promote GatewayAPIWithoutOLM to GA#2772gcs278 wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@gcs278: This pull request references NE-2520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
Hello @gcs278! Some important instructions when contributing to openshift/api: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe changes enable the ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.4)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c6220410-2306-11f1-9c3a-90af7c7cc380-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/23e6af60-2307-11f1-992d-12ede9d2e079-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/26a088fc-2307-11f1-9da4-6bca82f01e76-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e01ef8c0-2309-11f1-813c-239011e41911-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0198a9d0-233f-11f1-9a7d-ebebc862b301-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07dadcd0-2391-11f1-8c59-fe2512e5aad1-0 |
|
@gcs278: This pull request references NE-2520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ab81910-23c6-11f1-8635-bf728c1f5aad-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e4a3720-2406-11f1-93e5-9f16732fd0e5-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ddd5ec0-2493-11f1-8cf8-effe9a495bea-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/69a77f80-24c8-11f1-9403-ad1a7c99fb97-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8a761690-24c8-11f1-9c74-da2cb51d6692-0 |
|
@gcs278: This pull request references NE-2561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This pull request references NE-2520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6d5568f0-2710-11f1-9d03-561b26d4f2f7-0 |
This change promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default Feature Set (GA).
70d9187 to
64340c4
Compare
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8ca6afd0-2976-11f1-87dd-3a0e2dc903f1-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/899a4840-2978-11f1-88a5-2fdf52f0125a-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7c1b46a0-2979-11f1-9476-ac2dbf9a0ed8-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ad0efd0-297a-11f1-95c5-290d9ec10095-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/61957ad0-29e2-11f1-9921-6bbab26a3719-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/322df070-2bc1-11f1-9068-51d08a5996e8-0 |
|
@gcs278: This pull request references NE-2520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@gcs278 Quick scan of your results, you have no vSphere, SNO or metal testing at all presently. Is there a particular reason that this feature isn't applicable to any/all of those variants? |
|
@JoelSpeed We don't support Gateway API on SNO. For vsphere and metal - we are introducing support for baremetal in this pending release (4.22) via NE-2010. For context, we only added testing, no implementation needed. For our vsphere/baremetal testing, we use the pre-submit job e2e-vsphere-static-metallb-operator-gwapi in the CIO repo, though it's not configured for TechPreview. The testing was added as a pre-submit and not in origin E2E, the current Both this feature and NE-2010 are important for us in 4.22. Once this merges, the Either way, I could have been a bit more proactive in either creating a /pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-static-metallb-operator-gwapi |
|
Whoops, I think I need to use the payload-job command: |
|
@gcs278: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
I've added a PR for running the metal/vsphere techpreview Gateway API jobs, my hope is that we can use our pre-submit rehearsals to prove it won't break metal/vsphere: openshift/release#77188 |
This PR promotes the
GatewayAPIWithoutOLMfeature gate from TechPreviewNoUpgrade to Default (GA).Background
The
GatewayAPIWithoutOLMfeature replaces the OLM-based Istio installation method with direct Helm chart installation via the Sail library, enabling Gateway API support on clusters without OLM/Marketplace capabilities and avoiding conflicts with existing OSSM subscriptions.Related Work
Testing