Include candidate tier in default sippy queries for feature promotion

[yuqi-zhang]

Some job/platforms (MCO vsphere, metal) only run TechPreview tests in candidate-tier jobs. The default tier list used by QueriesFor() only included standard/informing/blocking, causing the feature promotion analyzer to report 0 tests found for these platforms.

This was the behaviour before #2763 and the partial fix in #2781, so the defaults should be fine to include candidate always.

Asked claude to add tests to verify the default queries include candidate tier and that all required variant definitions will query for it.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @yuqi-zhang! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: bb7f2107-c46a-491b-9f79-44f9e68d9f94

📥 Commits

Reviewing files that changed from the base of the PR and between 97ccba1 and 72cac06.

📒 Files selected for processing (3)

• tools/codegen/cmd/featuregate-test-analyzer.go
• tools/codegen/cmd/featuregate-test-analyzer_test.go
• tools/codegen/pkg/sippy/json_types.go

✅ Files skipped from review due to trivial changes (2)

• tools/codegen/cmd/featuregate-test-analyzer.go
• tools/codegen/cmd/featuregate-test-analyzer_test.go

🚧 Files skipped from review as they are similar to previous changes (1)

• tools/codegen/pkg/sippy/json_types.go

---

📝 Walkthrough

Walkthrough

This pull request updates the default job tier set used by the feature gate test analysis tools. The JobTiers field documentation in the job variant struct now states it defaults to "standard,informing,blocking,candidate" when empty. The QueriesFor function in the sippy package was changed to include the candidate tier in its default-generated queries. Tests were added to verify that query generation includes the candidate tier when JobTiers is empty for both self-managed and hypershift job variants.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[qodo-code-review]

Review Summary by Qodo

Include candidate tier in default Sippy queries

🐞 Bug fix 🧪 Tests

Walkthroughs

Description

• Include candidate tier in default Sippy queries for feature promotion
• Fixes MCO vsphere and metal platforms reporting zero tests for TechPreview
• Add comprehensive tests verifying candidate tier inclusion in queries
• Update documentation comments reflecting new default tier list

Diagram

flowchart LR
  A["QueriesFor function<br/>with empty JobTiers"] -->|"default tiers"| B["standard,informing,blocking,candidate"]
  B -->|"generates queries"| C["All required variants<br/>query candidate tier"]
  C -->|"fixes"| D["MCO vsphere/metal<br/>TechPreview tests"]

Loading

File Changes

1. tools/codegen/pkg/sippy/json_types.go 🐞 Bug fix +3/-3

Add candidate tier to default Sippy queries

• Updated default job tiers list from ["standard", "informing", "blocking"] to include
 "candidate"
• Modified two locations where empty jobTiers parameter defaults are set
• Updated comment documentation to reflect new default tier list

tools/codegen/pkg/sippy/json_types.go

---

2. tools/codegen/cmd/featuregate-test-analyzer.go 📝 Documentation +2/-2

Update documentation for candidate tier default

• Updated JobTiers field documentation comment to reflect new default including candidate tier
• Updated validateJobTiers function comment to document new default behavior

tools/codegen/cmd/featuregate-test-analyzer.go

---

3. tools/codegen/cmd/featuregate-test-analyzer_test.go 🧪 Tests +41/-0

Add tests for candidate tier query inclusion

• Added import for sippy package to enable query testing
• Added Test_defaultQueriesIncludeCandidateTier to verify candidate tier in default queries
• Added Test_allRequiredVariantsQueryCandidateTier to ensure all required variants query candidate
 tier
• Tests prevent regressions for candidate-tier jobs being excluded from analysis

tools/codegen/cmd/featuregate-test-analyzer_test.go

---

[qodo-code-review]

Code Review by Qodo

Looking for bugs?

Check back in a few minutes. An AI review agent is analyzing this pull request.

[yuqi-zhang]

Seems to be working via https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2790/pull-ci-openshift-api-master-verify-feature-promotion/2039396323941158912

[JoelSpeed]

/lgtm

[openshift-ci-robot]

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

• The changed files don't match any pipeline_run_if_changed patterns
• All files match pipeline_skip_if_only_changed patterns
• No pipeline-controlled jobs are defined for the master branch

Use /test ? to see all available tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/verified by @yuqi-zhang

[openshift-ci-robot]

@JoelSpeed: This PR has been marked as verified by @yuqi-zhang.

Details

In response to this:

/verified by @yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@yuqi-zhang: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.