Verify feature promotion test#2790
Conversation
Some job/platforms (MCO vsphere, metal) only run TechPreview tests in candidate-tier jobs. The default tier list used by QueriesFor() only included standard/informing/blocking, causing the feature promotion analyzer to report 0 tests found for these platforms. This was the behaviour before openshift#2763 and the partial fix in openshift#2781, so the defaults should be fine to include candidate always. Asked claude to add tests to verify the default queries include candidate tier and that all required variant definitions will query for it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hello @yuqi-zhang! Some important instructions when contributing to openshift/api: |
|
/test verify-feature promotion Trying it this way since #2738 (comment) seems to detect no diff against HEAD |
|
PR-Agent: could not fine a component named |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test verify-feature-promotion |
|
PR-Agent: could not fine a component named |
|
@yuqi-zhang: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.