NE-2664: add opt-in config to deploy haproxy as sidecar#1439
NE-2664: add opt-in config to deploy haproxy as sidecar#1439jcmoraisjr wants to merge 1 commit intoopenshift:masterfrom
Conversation
An opt-in configuration adds HAProxy as a sidecar container. This is a first but fully functional implementation that allows starting e2e and exploratory tests using the new topology. Key differences from a final version: * The same image is used both on router and haproxy containers; and * It is not possible to select HAProxy version. This is due to some other and still pending stories that will handle both a new API field and building HAProxy image for all supported versions. Note for testers: add 'haproxy-sidecar: "1"' annotation in the IngressController resource. This should create router pod with two containers, and it should behave in the same way as before. https://redhat.atlassian.net/browse/NE-2664
openshift-ci-robot
added
the
jira/valid-reference
|
@jcmoraisjr: This pull request references NE-2664 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jcmoraisjr: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
An opt-in configuration adds HAProxy as a sidecar container. This is a first but fully functional implementation that allows starting e2e and exploratory tests using the new topology.
Key differences from a final version:
This is due to some other and still pending stories that will handle both a new API field and building HAProxy image for all supported versions.
Note for testers: add 'haproxy-sidecar: "1"' annotation in the IngressController resource. This should create router pod with two containers, and it should behave in the same way as before.
https://redhat.atlassian.net/browse/NE-2664