Skip to content

OCPBUGS-55063: E2E: Use cpuset.CPUSet for reserved, isolated and offline fields - #1321

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
mrniranjan:use_cpuset
Apr 23, 2025
Merged

OCPBUGS-55063: E2E: Use cpuset.CPUSet for reserved, isolated and offline fields#1321
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
mrniranjan:use_cpuset

Conversation

@mrniranjan

@mrniranjan mrniranjan commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

When adding or removing cpus to reserved, isolated and offline use cpuset.CPUSet struct

@openshift-ci
openshift-ci Bot requested review from ffromani and jmencak April 14, 2025 13:32
@mrniranjan mrniranjan mentioned this pull request Apr 14, 2025
Merged
@mrniranjan mrniranjan changed the title Use cpuset.CPUSet for reserved, isolated and offline fields E2E: Use cpuset.CPUSet for reserved, isolated and offline fields Apr 15, 2025
@mrniranjan
Use cpuset.CPUSet for reserved, isolated and offline fields
c4aa565 
When adding or removing cpus to reserved, isolated and offline
use cpuset.CPUSet struct

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan

mrniranjan commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@mrniranjan

mrniranjan commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

/test okd-scos-e2e-aws-ovn

@mrniranjan

mrniranjan commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@mrniranjan

mrniranjan commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

/test okd-scos-e2e-aws-ovn

@mrniranjan

mrniranjan commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

ffromani
ffromani reviewed Apr 16, 2025
View reviewed changes

@ffromani ffromani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@ffromani

ffromani commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@openshift-ci

openshift-ci Bot commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2025
@mrniranjan mrniranjan changed the title E2E: Use cpuset.CPUSet for reserved, isolated and offline fields OCPBUGS-55063: E2E: Use cpuset.CPUSet for reserved, isolated and offline fields Apr 16, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 16, 2025
@openshift-ci-robot

openshift-ci-robot commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

@mrniranjan: This pull request references Jira Issue OCPBUGS-55063, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When adding or removing cpus to reserved, isolated and offline use cpuset.CPUSet struct

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mrniranjan.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@mrniranjan: This pull request references Jira Issue OCPBUGS-55063, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When adding or removing cpus to reserved, isolated and offline use cpuset.CPUSet struct

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrniranjan

mrniranjan commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@mrniranjan

mrniranjan commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci-robot

openshift-ci-robot commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4c4f38d and 2 for PR HEAD c4aa565 in total

2 similar comments
@openshift-ci-robot

openshift-ci-robot commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4c4f38d and 2 for PR HEAD c4aa565 in total

@openshift-ci-robot

openshift-ci-robot commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4c4f38d and 2 for PR HEAD c4aa565 in total

@mrniranjan

mrniranjan commented Apr 17, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@mrniranjan

mrniranjan commented Apr 17, 2025

Copy link
Copy Markdown
Contributor Author

/test e2e-hypershift

@openshift-ci-robot

openshift-ci-robot commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4c4f38d and 2 for PR HEAD c4aa565 in total

1 similar comment
@openshift-ci-robot

openshift-ci-robot commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4c4f38d and 2 for PR HEAD c4aa565 in total

@mrniranjan

mrniranjan commented Apr 18, 2025

Copy link
Copy Markdown
Contributor Author

/test e2e-upgrade

1 similar comment
@mrniranjan

mrniranjan commented Apr 18, 2025

Copy link
Copy Markdown
Contributor Author

/test e2e-upgrade

@openshift-ci-robot

openshift-ci-robot commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4c4f38d and 2 for PR HEAD c4aa565 in total

@openshift-ci-robot

openshift-ci-robot commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 727d8cd and 1 for PR HEAD c4aa565 in total

@openshift-ci-robot

openshift-ci-robot commented Apr 19, 2025

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7f2f68a and 0 for PR HEAD c4aa565 in total

@openshift-ci-robot

openshift-ci-robot commented Apr 19, 2025

Copy link
Copy Markdown
Contributor

/hold

Revision c4aa565 was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2025
@mrniranjan

mrniranjan commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@mrniranjan

mrniranjan commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2025
@openshift-ci-robot

openshift-ci-robot commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7f2f68a and 2 for PR HEAD c4aa565 in total

@mrniranjan

mrniranjan commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-ovn-techpreview

@openshift-ci

openshift-ci Bot commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 023668f into openshift:main Apr 23, 2025
@openshift-ci-robot

openshift-ci-robot commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

@mrniranjan: Jira Issue OCPBUGS-55063: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55063 has been moved to the MODIFIED state.

Details

In response to this:

When adding or removing cpus to reserved, isolated and offline use cpuset.CPUSet struct

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot

openshift-bot commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator
This PR has been included in build cluster-node-tuning-operator-container-v4.19.0-202504232224.p0.g023668f.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmencak jmencak Awaiting requested review from jmencak
1 more reviewer
@ffromani ffromani ffromani left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ffromani ffromani

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrniranjan @ffromani @openshift-ci-robot @openshift-bot