PSAP-1178: Add NetworkPolicy k8s resources - #1323
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jmencak: This pull request references PSAP-1178 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@jmencak Thanks for your work Jiri. |
This change adds a default deny NetworkPolicy for ingress and egress in the openshift-cluster-node-tuning-operator namespace. The following flows are allowed by NetworkPolicies: - access to the API server - access to NTO Metrics server - access to NTO Webhook server Resolves: PSAP-1178
343a3f0 to
1b61c36
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
jmencak
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
@rbaturov any chance for LGTM again? No changes apart from dropping the code change already adjusted elsewhere as you suggested. Thank you! |
|
/lgtm |
Thank you. Agreed. However, this might be tricky for TuneD pods. These are hostNetwork pods and the NetworkPolicy behaviour is undefined for that. |
|
@jmencak: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-node-tuning-operator |
NTO NetworkPolicy manifests that were added as part of openshift#1323 were missing Cluster Profile (https://github.com/openshift/enhancements/blob/master/enhancements/update/cluster-profiles.md) annotations. Add the missing Cluster Profile annotations, so that CVO does not ignore the NetworkPolicy manifests. include.release.openshift.io/self-managed-high-availability: "true" include.release.openshift.io/single-node-developer: "true" Also add NTO namespace to the "default-deny-all" policy. Resolves: OCPBUGS-99461
NTO NetworkPolicy manifests that were added as part of openshift#1323 were missing Cluster Profile (https://github.com/openshift/enhancements/blob/master/enhancements/update/cluster-profiles.md) annotations. Add the missing Cluster Profile annotations, so that CVO does not ignore the NetworkPolicy manifests. include.release.openshift.io/hypershift: "true" include.release.openshift.io/ibm-cloud-managed: "true" include.release.openshift.io/self-managed-high-availability: "true" include.release.openshift.io/single-node-developer: "true" Also add NTO namespace to the "default-deny-all" policy. Resolves: OCPBUGS-99461
4 participants
This change adds a default deny NetworkPolicy for ingress and egress in the openshift-cluster-node-tuning-operator namespace. The following flows are allowed by NetworkPolicies:
Resolves: PSAP-1178