Skip to content

[release-4.19] OCPBUGS-57148: E2E: Functional tests for align cpus by UncoreCache Feature - #1336

Merged
openshift-merge-bot[bot] merged 10 commits into
openshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-1302-to-release-4.19
Jun 23, 2025
Merged

[release-4.19] OCPBUGS-57148: E2E: Functional tests for align cpus by UncoreCache Feature#1336
openshift-merge-bot[bot] merged 10 commits into
openshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-1302-to-release-4.19

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 6, 2025

Copy link
Copy Markdown

This is an automated cherry-pick of #1302

/assign mrniranjan

mrniranjan added 10 commits June 6, 2025 06:51
@mrniranjan openshift-cherrypick-robot
Add function to wait for desired deployment status
2c2789a 
Add function WaitForDesiredDeploymentStatus to wait
for deployment to be in the desired status. This is
needed in cases where we reboot the node and want
to ascertain if the deployment has reached the desired
status

Minor fix: use existing context variable instead of creating
new context

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan openshift-cherrypick-robot
Add feature add additional tags to log messages
30e7e25 
Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan openshift-cherrypick-robot
Add function to fetch cpus of L3 Cache group
a1d7b7f 
Add function GetL3SharedCPUs which returns
a function which can be used to query the L3 cache
group of the cpu passed as argument.

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan openshift-cherrypick-robot
E2E: Add functional test cases for LLC
759c24e 
This commit adds functional test cases related to:
* Deploying pods using whole L3 cache group
* Rebooting the node with deployment
* Verifying deployment is alloted L3 cache group after kubelet restart
* Tests using multiple pods

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan openshift-cherrypick-robot
Add function to wait for deployment pods to be deleted
96a2e7a 
Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan openshift-cherrypick-robot
Use GetL3SharedCPUs function once and call the closure function to fe…
fe36b58 
…tch cpus.

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan openshift-cherrypick-robot
Get L3 Cache Group size to pod equivalent to its size
a399551 
Instead of using hard coded value , fetch the value
of L3 Cache group size and  use that value for the
guaranteed pod that we create

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan openshift-cherrypick-robot
use ginkgo context managment instead
bbbb9f0 
Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan openshift-cherrypick-robot
Use L3 Cache group associated with cpu 0 as reserved
f9280c3 
Use cpuset.CPUSet type for all reserved, isolated
variables when modifying performance profile

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan openshift-cherrypick-robot
Remove duplicate testlog.infof
fb51637 
Uncomment lines related to saving initialProfile

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 6, 2025
Merged
@openshift-ci-robot

openshift-ci-robot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-55989 has been cloned as Jira Issue OCPBUGS-57148. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-57148: E2E: Functional tests for align cpus by UncoreCache Feature

Details

In response to this:

This is an automated cherry-pick of #1302

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.19] OCPBUGS-55989: E2E: Functional tests for align cpus by UncoreCache Feature [release-4.19] OCPBUGS-57148: E2E: Functional tests for align cpus by UncoreCache Feature Jun 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 6, 2025
@openshift-ci-robot

openshift-ci-robot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-57148, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1302

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from Tal-or and yanirq June 6, 2025 06:51
@mrniranjan

mrniranjan commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 6, 2025
@openshift-ci-robot

openshift-ci-robot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

@mrniranjan: This pull request references Jira Issue OCPBUGS-57148, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-55989 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-55989 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @mrniranjan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested a review from mrniranjan June 6, 2025 06:58
@mrniranjan

mrniranjan commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

/retest-required

@yanirq

yanirq commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

/cc @ffromani

@openshift-ci
openshift-ci Bot requested a review from ffromani June 17, 2025 10:53
@ffromani

ffromani commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@mrniranjan

mrniranjan commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

/cherry-pick-approved

@ffromani

ffromani commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

/lgtm

straightforward backport

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2025
@mrniranjan

mrniranjan commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 18, 2025
@yanirq

yanirq commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@MarSik

MarSik commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 23, 2025
@openshift-ci

openshift-ci Bot commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 174ae08 into openshift:release-4.19 Jun 23, 2025
17 checks passed
@openshift-ci-robot

openshift-ci-robot commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-57148: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-57148 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1302

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot

openshift-bot commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator
This PR has been included in build cluster-node-tuning-operator-container-v4.19.0-202506231607.p0.g174ae08.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot

openshift-merge-robot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-06-24-180820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tal-or Tal-or Awaiting requested review from Tal-or
@yanirq yanirq Awaiting requested review from yanirq
@mrniranjan mrniranjan Awaiting requested review from mrniranjan
@ffromani ffromani Awaiting requested review from ffromani

Assignees

@mrniranjan mrniranjan

@ffromani ffromani

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @mrniranjan @yanirq @ffromani @MarSik @openshift-bot @openshift-merge-robot