Skip to content

[release-4.19] OCPBUGS-58144: E2E: Additional Functional tests for align cpus by UncoreCache Feature - #1348

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-1324-to-release-4.19
Jul 10, 2025
Merged

[release-4.19] OCPBUGS-58144: E2E: Additional Functional tests for align cpus by UncoreCache Feature#1348
openshift-merge-bot[bot] merged 3 commits into
openshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-1324-to-release-4.19

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 26, 2025

Copy link
Copy Markdown

This is an automated cherry-pick of #1324

/assign mrniranjan

@mrniranjan openshift-cherrypick-robot
E2E: Additional Functional tests for align cpus by UncoreCache Feature
d7055fb 
Adds  Additional tests related to CPUManager policy option
to align Cpus based on Uncore cache.

Contains tests related to Multiple Pods,
multiple containers  and with SMT disabled

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan openshift-cherrypick-robot
Use enum-like types for table driven test cases
a7a4592 
Instead of using string, the arguments to table
driven test cases are converted to enum-like variables
using constants.

Other Minor fixes like comparing cpuset variable using
inbuilt Equal operator

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan openshift-cherrypick-robot
Add comments and log messages for clear description
89877b9 
Add messages when assertions fail

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 26, 2025
Merged
@openshift-ci-robot

openshift-ci-robot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-57150 has been cloned as Jira Issue OCPBUGS-58144. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-58144: E2E: Additional Functional tests for align cpus by UncoreCache Feature

Details

In response to this:

This is an automated cherry-pick of #1324

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.19] OCPBUGS-57150: E2E: Additional Functional tests for align cpus by UncoreCache Feature [release-4.19] OCPBUGS-58144: E2E: Additional Functional tests for align cpus by UncoreCache Feature Jun 26, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 26, 2025
@openshift-ci-robot

openshift-ci-robot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-58144, which is invalid:

  • expected dependent Jira Issue OCPBUGS-57150 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1324

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from rbaturov and yanirq June 26, 2025 10:04
@mrniranjan

mrniranjan commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 26, 2025
@openshift-ci-robot

openshift-ci-robot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

@mrniranjan: This pull request references Jira Issue OCPBUGS-58144, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-57150 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-57150 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @mrniranjan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested a review from mrniranjan June 26, 2025 10:05
@openshift-ci

openshift-ci Bot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ffromani
ffromani reviewed Jul 3, 2025
View reviewed changes

@ffromani ffromani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
@openshift-ci

openshift-ci Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
@yanirq

yanirq commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@shajmakh

shajmakh commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci

openshift-ci Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

@shajmakh: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yanirq

yanirq commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 10, 2025
@openshift-merge-bot
openshift-merge-bot Bot merged commit 5a04656 into openshift:release-4.19 Jul 10, 2025
18 checks passed
@openshift-ci-robot

openshift-ci-robot commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-58144: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-58144 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1324

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot

openshift-bot commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator
This PR has been included in build cluster-node-tuning-operator-container-v4.19.0-202507101506.p0.g5a04656.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot

openshift-merge-robot commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-07-15-022514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbaturov rbaturov Awaiting requested review from rbaturov
@yanirq yanirq Awaiting requested review from yanirq
@mrniranjan mrniranjan Awaiting requested review from mrniranjan
1 more reviewer
@ffromani ffromani ffromani left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mrniranjan mrniranjan

@ffromani ffromani

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @mrniranjan @yanirq @shajmakh @openshift-bot @openshift-merge-robot @ffromani