[WIP] CONSOLE-2501: Bump Typescript to v4.2.4 #10604
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
rebeccaalpert
changed the title
rebeccaalpert
changed the title
openshift-ci
bot
added
component/dashboard
rebeccaalpert
force-pushed
the
ts4-rebecca
branch
from
6973dce to
28283a5
Compare
openshift-ci
bot
removed
the
needs-rebase
rebeccaalpert
force-pushed
the
ts4-rebecca
branch
2 times, most recently
from
047543a to
0f9a4ce
Compare
openshift-ci
bot
added
needs-rebase
rebeccaalpert
force-pushed
the
ts4-rebecca
branch
from
7b3b4b5 to
b65621d
Compare
rebeccaalpert
force-pushed
the
ts4-rebecca
branch
from
a89a2c5 to
1c49b60
Compare
rebeccaalpert
force-pushed
the
ts4-rebecca
branch
from
423f58b to
e478a73
Compare
rebeccaalpert
force-pushed
the
ts4-rebecca
branch
2 times, most recently
from
6d205c6 to
ac182a3
Compare
rebeccaalpert
force-pushed
the
ts4-rebecca
branch
from
ac182a3 to
c91e233
Compare
Changes introduce a lot of additional TS errors in tests; I would rather ensure that all tests are working first before I return to this.
Contributor
|
@rebeccaalpert: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
rebeccaalpert
force-pushed
the
ts4-rebecca
branch
5 times, most recently
from
2e7858e to
0f29513
Compare
rebeccaalpert
force-pushed
the
ts4-rebecca
branch
from
0f29513 to
e4081b2
Compare
Contributor
|
@rebeccaalpert: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Kim, I am opening a new PR based on Gilad's TypeScript work: #10432.
I will fix tests and try to resolve open issues.
Related to https://issues.redhat.com/projects/CONSOLE/issues/CONSOLE-2501.
Note: I am upgrading Jest to the latest version as part of this PR. I attempted a smaller upgrade (upgrade was necessary), but ran into issues and poor error messaging. The version we were using was so old there is no documentation, and documentation was sparse on the next major release.
The latest version has improved messaging and it is easier to mock modules. The next version bump will deprecate Jasmine. This PR will remove only the broken Jasmine calls. We will need to plan on removing any remaining Jasmine calls the next time we upgrade.