Skip to content

Incorporate vertical scroll shadows to modals#1128

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sg00dwin:modal-vertical-scroll-shadows
Jan 30, 2019
Merged

Incorporate vertical scroll shadows to modals#1128
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sg00dwin:modal-vertical-scroll-shadows

Conversation

@sg00dwin
Copy link
Copy Markdown
Member

@sg00dwin sg00dwin commented Jan 23, 2019

  • shared css for react-modal and patternfly-react modal
  • modal-content class is now a child of modal-dialog
  • pf overrides for catalog height and positioning to support scroll shadows
  • button, input, tag elements have colors switched to rgba so don't overlay shadow

modals-scroll-shadows
dev-catalog-scroll-shadows
android-scroll-shadows
ios-dev-catalog-scroll-shadows

@sg00dwin sg00dwin requested review from rhamilto and spadgett January 23, 2019 17:58
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2019
@sg00dwin sg00dwin force-pushed the modal-vertical-scroll-shadows branch from 399bdd5 to a65c6bb Compare January 23, 2019 20:18
@spadgett
Copy link
Copy Markdown
Member

spadgett commented Jan 24, 2019

/retest

@spadgett
Copy link
Copy Markdown
Member

spadgett commented Jan 24, 2019

/refresh
/skip

@spadgett
Copy link
Copy Markdown
Member

spadgett commented Jan 28, 2019

/assign @rhamilto

rhamilto
rhamilto reviewed Jan 28, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job moving us toward consolidated modals and improving their funcitonality!

Comment thread frontend/public/components/modals/_modals.scss Outdated
Copy link
Copy Markdown
Member

@rhamilto rhamilto Jan 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIt: alpha

Comment thread frontend/public/components/modals/_modals.scss Outdated
Copy link
Copy Markdown
Member

@rhamilto rhamilto Jan 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment explaining why 20px?

Comment thread frontend/public/components/modals/_modals.scss Outdated
Copy link
Copy Markdown
Member

@rhamilto rhamilto Jan 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives me pause since it's redefining the buttons style from PatternFly. If/when those change, we will now have to update this rule as well.

Comment thread frontend/public/style/_overrides.scss Outdated
Copy link
Copy Markdown
Member

@rhamilto rhamilto Jan 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: indentation.

Comment thread frontend/public/components/modals/_modals.scss Outdated
Comment thread frontend/public/components/modals/_modals.scss Outdated
Comment thread frontend/public/components/modals/add-secret-to-workload.tsx Outdated
Comment thread frontend/public/components/modals/_modals.scss Outdated
Copy link
Copy Markdown
Member

@rhamilto rhamilto Jan 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem undesirable for short modals?

screen shot 2019-01-28 at 10 09 56 am

Copy link
Copy Markdown
Member Author

@sg00dwin sg00dwin Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2019-01-30 at 12 02 52 pm

Comment thread frontend/public/components/modals/delete-modal.jsx Outdated
Copy link
Copy Markdown
Member

@rhamilto rhamilto Jan 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the passing of className here overrides the default classNames in modal.tsx. As a result, this modal doesn't get the height adjustments. Is that intentional?

Comment thread frontend/public/components/modals/delete-namespace-modal.jsx Outdated
Copy link
Copy Markdown
Member

@rhamilto rhamilto Jan 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the passing of className here overrides the default classNames in modal.tsx. As a result, this modal doesn't get the height adjustments. Is that intentional?

@sg00dwin sg00dwin force-pushed the modal-vertical-scroll-shadows branch 2 times, most recently from 6398423 to 4190d6a Compare January 30, 2019 17:01
@sg00dwin
Copy link
Copy Markdown
Member Author

sg00dwin commented Jan 30, 2019

@rhamilto changes push. please take a look.

size options
screen shot 2019-01-30 at 11 57 34 am
screen shot 2019-01-30 at 11 57 54 am
screen shot 2019-01-30 at 11 58 04 am

rhamilto
rhamilto approved these changes Jan 30, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread frontend/public/components/modals/_modals.scss Outdated
Copy link
Copy Markdown
Member

@rhamilto rhamilto Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra blank line

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019
@sg00dwin
Incorporate vertical scroll shadows to modals
415a38c 
- modal-content class is now a child of modal-dialog
- shared css for react-modal and patternfly-react modal
- add modal optional height classes
- pf overrides for catalog height and positioning to support scroll shadows
@sg00dwin sg00dwin force-pushed the modal-vertical-scroll-shadows branch from 4190d6a to 415a38c Compare January 30, 2019 18:04
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019
@rhamilto
Copy link
Copy Markdown
Member

rhamilto commented Jan 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1847490 into openshift:master Jan 30, 2019
@sg00dwin sg00dwin deleted the modal-vertical-scroll-shadows branch January 31, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@josephschorr josephschorr Awaiting requested review from josephschorr

Assignees

@rhamilto rhamilto

Labels

lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sg00dwin @spadgett @rhamilto @openshift-ci-robot @openshift-merge-robot