Skip to content

Monitoring: Hide column on small screens to fix menu / text overlap#1139

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kyoto:monitoring-fix-mobile-list-cols
Jan 25, 2019
Merged

Monitoring: Hide column on small screens to fix menu / text overlap#1139
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kyoto:monitoring-fix-mobile-list-cols

Conversation

@kyoto
Copy link
Copy Markdown
Member

@kyoto kyoto commented Jan 25, 2019

/cc @cshinn

Fixes https://jira.coreos.com/browse/MON-524

Before After
Alerts alerts-before alerts-after
Silences silences-before silences-after

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 25, 2019
spadgett
spadgett approved these changes Jan 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2019
cshinn
cshinn approved these changes Jan 25, 2019
View reviewed changes
Copy link
Copy Markdown

@cshinn cshinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spadgett
Copy link
Copy Markdown
Member

spadgett commented Jan 25, 2019

Overview flake, @TheRealJon fyi

/retest

1) Visiting Overview page Stateful Sets : shows statefulset details sidebar when item is clicked
   Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
       at ontimeout timers.js:427:11
       at tryOnTimeout timers.js:289:5
       at listOnTimeout timers.js:252:5
       at Timer.processTimers timers.js:212:10

@openshift-merge-robot openshift-merge-robot merged commit 869e297 into openshift:master Jan 25, 2019
@kyoto kyoto deleted the monitoring-fix-mobile-list-cols branch January 26, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

+1 more reviewer

@cshinn cshinn cshinn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spadgett spadgett

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kyoto @spadgett @cshinn @openshift-ci-robot @openshift-merge-robot