Prevent operator icons from stretching in operator subscription page#1150
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jan 30, 2019
Merged
Conversation
openshift-ci-robot
added
the
size/XS
jeff-phillips-18
force-pushed
the
fixes
branch
from
a0ce0d3 to
1a893fa
Compare
Member
|
/assign @rhamilto |
jeff-phillips-18
force-pushed
the
fixes
branch
from
1a893fa to
321d7eb
Compare
openshift-ci-robot
added
size/S
Member
|
We should be using https://github.com/openshift/console/blob/master/frontend/public/components/catalog/_catalog.scss#L92-L100 to eliminate duplication of styles? |
Member
Author
|
I can do that. Or I can create a new style under |
jeff-phillips-18
force-pushed
the
fixes
branch
from
321d7eb to
dd75725
Compare
Member
Author
|
I've used the |
Member
|
/lgtm |
jeff-phillips-18
force-pushed
the
fixes
branch
from
dd75725 to
d43e53f
Compare
Member
Author
|
Add fix to https://jira.coreos.com/browse/CONSOLE-1237 as well since its in the same realm. |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1669304
Fixes https://jira.coreos.com/browse/CONSOLE-1237