Bug 1906745: Upgrade Helm to 3.4.2 by maysunfaisal · Pull Request #7517 · openshift/console

maysunfaisal · 2020-12-10T17:44:09Z

This is for issue https://issues.redhat.com/browse/HELM-47

upgrades Helm go module to 3.4.2
go mod tidy & go mod vendor
updates all the test index files for Helm 3.4.2

P.S.
If you're coming back to look at this PR for googleapis vendor changes, the module path changed from vendor/github.com/googleapis/gnostic/OpenAPIv2 to vendor/github.com/googleapis/gnostic/openapiv2

You may set the git config to take this into account

 git config core.ignorecase false

pedjak · 2020-12-11T10:00:30Z

/lgtm
/approved

pedjak · 2020-12-11T10:58:22Z

/retitle Bug 1906745: Upgrade Helm to 3.4.1

openshift-ci-robot · 2020-12-11T10:58:45Z

@maysunfaisal: This pull request references Bugzilla bug 1906745, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1906745: Upgrade Helm to 3.4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pedjak · 2020-12-11T10:59:27Z

/bugzilla-refresh

pedjak · 2020-12-11T11:00:37Z

@maysunfaisal the latest version is 3.4.2, so since we perform update now, let's upgrade to that instead?

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>

pedjak · 2020-12-11T16:52:56Z

/retitle Bug 1906745: Upgrade Helm to 3.4.2

pedjak · 2020-12-11T16:53:13Z

/lgtm

openshift-ci-robot · 2020-12-11T17:14:01Z

@maysunfaisal: This pull request references Bugzilla bug 1906745, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1906745: Upgrade Helm to 3.4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maysunfaisal · 2020-12-11T17:18:50Z

/bugzilla refresh

openshift-ci-robot · 2020-12-11T17:18:53Z

@maysunfaisal: This pull request references Bugzilla bug 1906745, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2020-12-11T17:22:29Z

/bugzilla refresh

openshift-ci-robot · 2020-12-11T17:22:34Z

@andrewballantyne: This pull request references Bugzilla bug 1906745, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pedjak · 2020-12-11T17:23:24Z

/bugzilla-refresh

andrewballantyne · 2020-12-11T17:23:58Z

/assign @spadgett @jhadvig

This is related to the work in #7424 and a continuation of the lib issue in #7299

spadgett

/approve

openshift-ci-robot · 2020-12-11T17:45:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashshinde, maysunfaisal, pedjak, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

akashshinde · 2020-12-11T17:56:00Z

/retest

openshift-ci-robot · 2020-12-12T00:13:57Z

@maysunfaisal: All pull requests linked via external trackers have merged:

openshift/console#7517

Bugzilla bug 1906745 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1906745: Upgrade Helm to 3.4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from akashshinde and rhamilto December 10, 2020 17:44

openshift-ci-robot added the component/backend Related to backend label Dec 10, 2020

maysunfaisal force-pushed the HELM-47-1 branch from a36719f to a809560 Compare December 10, 2020 18:00

openshift-ci-robot assigned pedjak Dec 11, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020

openshift-ci-robot changed the title ~~Upgrade Helm to 3.4.1 & update Helm test index files~~ Bug 1906745: Upgrade Helm to 3.4.1 Dec 11, 2020

openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Dec 11, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 11, 2020

Upgrade Helm and update helm index file tests

f52cad4

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>

maysunfaisal force-pushed the HELM-47-1 branch from a809560 to f52cad4 Compare December 11, 2020 16:05

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020

openshift-ci-robot changed the title ~~Bug 1906745: Upgrade Helm to 3.4.1~~ Bug 1906745: Upgrade Helm to 3.4.2 Dec 11, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 11, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 11, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 11, 2020

openshift-ci-robot assigned jhadvig and spadgett Dec 11, 2020

spadgett approved these changes Dec 11, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020

akashshinde approved these changes Dec 11, 2020

View reviewed changes

openshift-merge-robot merged commit 90601e0 into openshift:master Dec 12, 2020

spadgett added this to the v4.7 milestone Jan 7, 2021

Conversation

maysunfaisal commented Dec 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedjak commented Dec 11, 2020

Uh oh!

pedjak commented Dec 11, 2020

Uh oh!

openshift-ci-robot commented Dec 11, 2020

Uh oh!

pedjak commented Dec 11, 2020

Uh oh!

pedjak commented Dec 11, 2020

Uh oh!

pedjak commented Dec 11, 2020

Uh oh!

pedjak commented Dec 11, 2020

Uh oh!

openshift-ci-robot commented Dec 11, 2020

Uh oh!

maysunfaisal commented Dec 11, 2020

Uh oh!

openshift-ci-robot commented Dec 11, 2020

Uh oh!

andrewballantyne commented Dec 11, 2020

Uh oh!

openshift-ci-robot commented Dec 11, 2020

Uh oh!

pedjak commented Dec 11, 2020

Uh oh!

andrewballantyne commented Dec 11, 2020

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Dec 11, 2020

Uh oh!

akashshinde commented Dec 11, 2020

Uh oh!

openshift-ci-robot commented Dec 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

maysunfaisal commented Dec 10, 2020 •

edited

Loading