Skip to content

USHIFT-1371: Test agent for testing ostree upgrade failures#1971

Merged
openshift-merge-robot merged 1 commit into
openshift:mainfrom
pmtk:1371-failure-agent
Jun 30, 2023
Merged

USHIFT-1371: Test agent for testing ostree upgrade failures#1971
openshift-merge-robot merged 1 commit into
openshift:mainfrom
pmtk:1371-failure-agent

Conversation

@pmtk

@pmtk pmtk commented Jun 28, 2023

Copy link
Copy Markdown
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2023
@openshift-ci-robot

openshift-ci-robot commented Jun 28, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@pmtk: This pull request references USHIFT-1371 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2023
@openshift-ci openshift-ci Bot requested review from dhellmann and ggiguash June 28, 2023 15:24
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
dhellmann
dhellmann reviewed Jun 28, 2023
View reviewed changes
Comment thread test/failure-agent/microshift-failure-agent.sh Outdated

@dhellmann dhellmann Jun 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because it is a service? Is there not a way to specify that something runs once and exits?

@pmtk pmtk Jun 29, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want it to exit.
For example, I want to simulate that making a backup on first boot of new deployment fails, but I want it to succeed on second boot (greenboot's reboot) - for this reason, I want this service to last up until the shutdown and revert chattr - otherwise it'll be present in rolled back deployment as well

@dhellmann dhellmann Jun 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see what you're going for. I'm a little worried about relying on a clean exit handler, but let's see how it works in practice. If we find issues we can look at options like persisting the instructions for each boot separately.

dhellmann
dhellmann reviewed Jun 29, 2023
View reviewed changes

@dhellmann dhellmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2023
@pmtk pmtk force-pushed the 1371-failure-agent branch from 3e21433 to 905f8b9 Compare June 30, 2023 10:36
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2023
@pmtk pmtk changed the title WIP USHIFT-1371: Failure agent for testing USHIFT-1371: Failure agent for testing Jun 30, 2023
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2023
@pmtk

pmtk commented Jun 30, 2023

Copy link
Copy Markdown
Member Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@pmtk pmtk force-pushed the 1371-failure-agent branch from 905f8b9 to 8c2c096 Compare June 30, 2023 11:15
@pmtk

pmtk commented Jun 30, 2023

Copy link
Copy Markdown
Member Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@pmtk pmtk force-pushed the 1371-failure-agent branch from 8c2c096 to 4e14a0c Compare June 30, 2023 11:33
@pmtk

pmtk commented Jun 30, 2023

Copy link
Copy Markdown
Member Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@pmtk pmtk force-pushed the 1371-failure-agent branch from 4e14a0c to 9a56b1c Compare June 30, 2023 17:05
@pmtk pmtk changed the title USHIFT-1371: Failure agent for testing USHIFT-1371: Test agent for testing ostree upgrade failures Jun 30, 2023
@pmtk

pmtk commented Jun 30, 2023

Copy link
Copy Markdown
Member Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@pmtk pmtk force-pushed the 1371-failure-agent branch from 9a56b1c to e7fd791 Compare June 30, 2023 17:08
dhellmann
dhellmann reviewed Jun 30, 2023
View reviewed changes

@dhellmann dhellmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice. We can add a build for this RPM to the scenario steps when that code lands.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2023
@openshift-ci

openshift-ci Bot commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm e7fd791 link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit bb7eb78 into openshift:main Jun 30, 2023
@pmtk pmtk deleted the 1371-failure-agent branch July 3, 2023 07:25
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request May 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhellmann dhellmann dhellmann left review comments

@ggiguash ggiguash Awaiting requested review from ggiguash

Assignees

@dhellmann dhellmann

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pmtk @openshift-ci-robot @dhellmann @openshift-merge-robot