Skip to content

NO-ISSUE: Fix configure-vm.sh script to work on CentOS 9 Stream#1976

Merged
openshift-merge-robot merged 1 commit into
openshift:mainfrom
ggiguash:fix_centos_devenv
Jun 30, 2023
Merged

NO-ISSUE: Fix configure-vm.sh script to work on CentOS 9 Stream#1976
openshift-merge-robot merged 1 commit into
openshift:mainfrom
ggiguash:fix_centos_devenv

Conversation

@ggiguash

@ggiguash ggiguash commented Jun 29, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor
  • Need to install openshift-clients RPM because MicroShift PRM depends on it explicitly
  • Make sure to enable crun runtime in /etc/crio/crio.conf if not already enabled

Closes #1965
USHIFT-1341

@openshift-ci openshift-ci Bot requested review from dhellmann and pmtk June 29, 2023 15:05
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2023
@ggiguash ggiguash mentioned this pull request Jun 29, 2023
Closed
@ggiguash ggiguash changed the title NO=ISSUE: Fix configure-vm.sh script to work on CentOS 9 Stream NO-ISSUE: Fix configure-vm.sh script to work on CentOS 9 Stream Jun 29, 2023
@openshift-ci-robot

openshift-ci-robot commented Jun 29, 2023

Copy link
Copy Markdown

@ggiguash: This pull request explicitly references no jira issue.

Details

In response to this:

  • Need to install openshift-clients RPM because MicroShift PRM depends on it explicitly
  • Make sure to enable crun runtime on crio if not already enabled

Closes #1965

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 29, 2023
@openshift-ci-robot

openshift-ci-robot commented Jun 29, 2023

Copy link
Copy Markdown

@ggiguash: This pull request explicitly references no jira issue.

Details

In response to this:

  • Need to install openshift-clients RPM because MicroShift PRM depends on it explicitly
  • Make sure to enable crun runtime in /etc/crio/crio.conf if not already enabled

Closes #1965

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci

openshift-ci Bot commented Jun 29, 2023

Copy link
Copy Markdown
Contributor

@ggiguash: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm 07665e6 link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann

dhellmann commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2023
@openshift-ci

openshift-ci Bot commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6987b66 into openshift:main Jun 30, 2023
@ggiguash ggiguash deleted the fix_centos_devenv branch July 10, 2023 09:12
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request May 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhellmann dhellmann Awaiting requested review from dhellmann

@pmtk pmtk Awaiting requested review from pmtk

Assignees

@dhellmann dhellmann

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] ./scripts/devenv-builder/configure-vm.sh: nothing provides openshift-clients needed by microshift

4 participants

@ggiguash @openshift-ci-robot @dhellmann @openshift-merge-robot