Skip to content

chore: pkg imported more than once#1991

Merged
openshift-merge-robot merged 1 commit into
openshift:mainfrom
testwill:pkg-import
Jul 5, 2023
Merged

chore: pkg imported more than once#1991
openshift-merge-robot merged 1 commit into
openshift:mainfrom
testwill:pkg-import

Conversation

@testwill

@testwill testwill commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Which issue(s) this PR addresses:

Closes #

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@openshift-ci openshift-ci Bot requested review from dhellmann and pacevedom July 4, 2023 03:56
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 4, 2023
@openshift-ci

openshift-ci Bot commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Hi @testwill. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann

Copy link
Copy Markdown
Contributor

/assign @benluddy @pmtk

Is there any benefit to having the package imported using different names, or was this just an oversight?

@benluddy

benluddy commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023
@dhellmann

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2023
@openshift-ci

openshift-ci Bot commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

@testwill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-e2e-arm f430c92 link false /test microshift-e2e-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann

Copy link
Copy Markdown
Contributor

/approve

Thank you, @testwill !

@openshift-ci

openshift-ci Bot commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, dhellmann, testwill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit f88562b into openshift:main Jul 5, 2023
@testwill testwill deleted the pkg-import branch July 6, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants