USHIFT-1364: Don't overwrite health if backup wasn't created

[pmtk]

Taking a backup is very important and we don't want to lose information that it should be done.
This change adds handling of situation where MicroShift is unhealthy because it couldn't make a backup and it should attempt to do it after reboot and after rollback: "don't overwrite 'backup' request if it wasn't created".

[openshift-ci-robot]

@pmtk: This pull request references USHIFT-1364 which is a valid jira issue.

Details

In response to this:

Taking a backup is very important and we don't want to lose information that it should be done.
This change adds handling of situation where MicroShift is unhealthy because it couldn't make a backup and it should attempt to do it after reboot and after rollback: "don't overwrite 'backup' request if it wasn't created".

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dhellmann]

Suggested change

	echo "Not overwriting the health.json to retry backup on next boot"
	echo "Not overwriting the health.json, will retry backup on next boot"

Does this change convey the same meaning? If so, it's a little more explicit.

[dhellmann]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dhellmann,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@pmtk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm	b7ff9d0	link	false	/test e2e-openshift-conformance-reduced-arm
ci/prow/microshift-e2e-arm	b7ff9d0	link	false	/test microshift-e2e-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.