Skip to content

Fix panic on buggy kustomization, add retries#261

Merged
rootfs merged 2 commits into
mainfrom
fix-208-kustomizer
Sep 15, 2021
Merged

Fix panic on buggy kustomization, add retries#261
rootfs merged 2 commits into
mainfrom
fix-208-kustomizer

Conversation

@fzdarsky

Copy link
Copy Markdown
Contributor

Signed-off-by: Frank A. Zdarsky fzdarsky@redhat.com

Closes #208

Signed-off-by: Frank A. Zdarsky <fzdarsky@redhat.com>
@openshift-ci openshift-ci Bot requested review from copejon and oglok September 10, 2021 12:49
@fzdarsky fzdarsky self-assigned this Sep 10, 2021
Comment thread pkg/kustomize/apply.go Outdated
Signed-off-by: Frank A. Zdarsky <fzdarsky@redhat.com>
@rootfs

rootfs commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@rootfs rootfs merged commit 5d4b7dd into main Sep 15, 2021
@fzdarsky fzdarsky deleted the fix-208-kustomizer branch September 15, 2021 17:05
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
@openshift-ci

openshift-ci Bot commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rootfs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Kustomizer makes Microshift to crash if manifest is not validated

2 participants