Skip to content

USHIFT-3260: Fix build_bootc_images to be more robust when processing versions#3406

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
ggiguash:bootc_build_fix
May 30, 2024
Merged

USHIFT-3260: Fix build_bootc_images to be more robust when processing versions#3406
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
ggiguash:bootc_build_fix

Conversation

@ggiguash

@ggiguash ggiguash commented May 29, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2024
@openshift-ci

openshift-ci Bot commented May 29, 2024

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ggiguash

ggiguash commented May 29, 2024

Copy link
Copy Markdown
Contributor Author

/test ?

@openshift-ci

openshift-ci Bot commented May 29, 2024

Copy link
Copy Markdown
Contributor

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-bootc-test
  • pull-ci-openshift-microshift-main-metal-bootc-test-arm
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-metal-periodic-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash

ggiguash commented May 29, 2024

Copy link
Copy Markdown
Contributor Author

/test metal-bootc-test

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@ggiguash ggiguash changed the title Fix build_bootc_images to be more robust when processing versions USHIFT-3260: Fix build_bootc_images to be more robust when processing versions May 29, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 29, 2024
@openshift-ci-robot

openshift-ci-robot commented May 29, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-3260 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash

ggiguash commented May 29, 2024

Copy link
Copy Markdown
Contributor Author

/test metal-bootc-test

@ggiguash ggiguash marked this pull request as ready for review May 29, 2024 11:57
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2024
@openshift-ci openshift-ci Bot requested review from jerpeter1 and pliurh May 29, 2024 12:00
pacevedom
pacevedom approved these changes May 29, 2024
View reviewed changes

@pacevedom pacevedom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
@openshift-ci

openshift-ci Bot commented May 29, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

openshift-ci-robot commented May 29, 2024

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 3743367 and 2 for PR HEAD 620fa95 in total

@openshift-ci-robot

openshift-ci-robot commented May 29, 2024

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD fe5d840 and 1 for PR HEAD 620fa95 in total

@ggiguash

ggiguash commented May 30, 2024

Copy link
Copy Markdown
Contributor Author

/retest-required

@ggiguash

ggiguash commented May 30, 2024

Copy link
Copy Markdown
Contributor Author

The changes do not affect non-bootc periodic tests. Overriding to save CI cycles.
/override ci/prow/metal-periodic-test ci/prow/metal-periodic-test-arm

@openshift-ci

openshift-ci Bot commented May 30, 2024

Copy link
Copy Markdown
Contributor

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test, ci/prow/metal-periodic-test-arm

Details

In response to this:

The changes do not affect non-bootc periodic tests. Overriding to save CI cycles.
/override ci/prow/metal-periodic-test ci/prow/metal-periodic-test-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pacevedom

pacevedom commented May 30, 2024

Copy link
Copy Markdown
Contributor

/retest-required

@openshift-ci

openshift-ci Bot commented May 30, 2024

Copy link
Copy Markdown
Contributor

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 83a058b into openshift:main May 30, 2024
@ggiguash ggiguash deleted the bootc_build_fix branch May 30, 2024 12:53
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request Nov 13, 2024
Closed
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pacevedom pacevedom pacevedom approved these changes

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@pliurh pliurh Awaiting requested review from pliurh

Assignees

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggiguash @openshift-ci-robot @pacevedom