Skip to content

[release-4.17] USHIFT-706: Add CSI Deployment Flag and Config#3748

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.17from
openshift-cherrypick-robot:cherry-pick-3678-to-release-4.17
Aug 9, 2024
Merged

[release-4.17] USHIFT-706: Add CSI Deployment Flag and Config#3748
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.17from
openshift-cherrypick-robot:cherry-pick-3678-to-release-4.17

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Aug 9, 2024

Copy link
Copy Markdown

This is an automated cherry-pick of #3678

/assign copejon

@copejon
implementation of Optional CSI Config: openshift/enhancements#1635
69bd674 
expand microshift config with new storage root field. allows users to disable LVMS and/or CSI components

Signed-off-by: Jon Cope <jcope@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 9, 2024
Merged
4 tasks
@openshift-ci-robot

openshift-ci-robot commented Aug 9, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: USHIFT-706

Details

In response to this:

This is an automated cherry-pick of #3678

/assign copejon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from jerpeter1 and pacevedom August 9, 2024 16:39
@copejon

copejon commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

/retest-required

@copejon

copejon commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2024
@copejon

copejon commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@copejon

copejon commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 9, 2024
@openshift-ci-robot

openshift-ci-robot commented Aug 9, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@copejon: This pull request references USHIFT-706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
@openshift-ci

openshift-ci Bot commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhensel-rh

dhensel-rh commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 9, 2024
@copejon

copejon commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

/backport-risk-assessed

@openshift-ci

openshift-ci Bot commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jerpeter1

jerpeter1 commented Aug 9, 2024

Copy link
Copy Markdown
Member

/label backport-risk-assessed

@openshift-ci

openshift-ci Bot commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

@jerpeter1: Can not set label backport-risk-assessed: Must be member in one of these teams: []

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jerpeter1

jerpeter1 commented Aug 9, 2024

Copy link
Copy Markdown
Member

/check-required-labels

@copejon

copejon commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Aug 9, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@copejon: This pull request references USHIFT-706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@copejon

copejon commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 9, 2024
@copejon

copejon commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

/label jira/valid-bug

@openshift-ci openshift-ci Bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 9, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit e264c90 into openshift:release-4.17 Aug 9, 2024
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request Jan 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@pacevedom pacevedom Awaiting requested review from pacevedom

Assignees

@copejon copejon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @copejon @dhensel-rh @jerpeter1