Skip to content

USHIFT-4335 USHIFT-4354 USHIFT-4356: build runnable microshift-okd bootc container#3830

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
eslutsky:okd-rebase
Sep 19, 2024
Merged

USHIFT-4335 USHIFT-4354 USHIFT-4356: build runnable microshift-okd bootc container#3830
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
eslutsky:okd-rebase

Conversation

@eslutsky

@eslutsky eslutsky commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2024
@openshift-ci openshift-ci Bot requested review from ggiguash and pacevedom August 29, 2024 16:46
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@eslutsky eslutsky marked this pull request as draft August 30, 2024 09:59
ggiguash
ggiguash reviewed Aug 30, 2024
View reviewed changes
Comment thread test/bin/ci_phase_iso_build.sh Outdated
@eslutsky

eslutsky commented Aug 30, 2024

Copy link
Copy Markdown
Contributor Author

/test ci/prow/microshift-metal-tests

@openshift-ci

openshift-ci Bot commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

@eslutsky: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test footprint-and-performance
  • /test images
  • /test metal-bootc-periodic-test
  • /test metal-bootc-periodic-test-arm
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test ocp-full-conformance-rhel-eus
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-release-4.17-images
  • pull-ci-openshift-microshift-release-4.17-metal-bootc-periodic-test
  • pull-ci-openshift-microshift-release-4.17-metal-bootc-periodic-test-arm
  • pull-ci-openshift-microshift-release-4.17-metal-bootc-test
  • pull-ci-openshift-microshift-release-4.17-metal-bootc-test-arm
  • pull-ci-openshift-microshift-release-4.17-metal-periodic-test
  • pull-ci-openshift-microshift-release-4.17-metal-periodic-test-arm
  • pull-ci-openshift-microshift-release-4.17-microshift-metal-cache
  • pull-ci-openshift-microshift-release-4.17-microshift-metal-cache-arm
  • pull-ci-openshift-microshift-release-4.17-microshift-metal-tests
  • pull-ci-openshift-microshift-release-4.17-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-release-4.17-test-unit
  • pull-ci-openshift-microshift-release-4.17-verify
Details

In response to this:

/test ci/prow/microshift-metal-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eslutsky

eslutsky commented Aug 30, 2024

Copy link
Copy Markdown
Contributor Author

/test microshift-metal-tests

@eslutsky

eslutsky commented Aug 30, 2024

Copy link
Copy Markdown
Contributor Author

/test microshift-metal-tests

@eslutsky eslutsky changed the title WIP: Test only: replace to okd released assets USHIFT-4120: Test only: replace to okd released assets Aug 30, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 30, 2024
@openshift-ci-robot

openshift-ci-robot commented Aug 30, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@eslutsky: This pull request references USHIFT-4120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eslutsky

eslutsky commented Aug 30, 2024

Copy link
Copy Markdown
Contributor Author

/test microshift-metal-tests

@eslutsky

eslutsky commented Aug 30, 2024

Copy link
Copy Markdown
Contributor Author

so most of the assets can be replaced and passes our tests.

except two which are missing in the okd release:

error: no image tag "lvms_operator" exists in the release image quay.io/okd/scos-release:4.17.0-0.okd-scos-2024-08-21-
error: no image tag "openssl" exists in the release image quay.io/okd/scos-release:4.17.0-0.okd-scos-2024-08-21-100712

@copejon

copejon commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

so most of the assets can be replaced and passes our tests.

except two which are missing in the okd release:

error: no image tag "lvms_operator" exists in the release image quay.io/okd/scos-release:4.17.0-0.okd-scos-2024-08-21-
error: no image tag "openssl" exists in the release image quay.io/okd/scos-release:4.17.0-0.okd-scos-2024-08-21-100712

There isn't a community repo for LVMS at the moment. Previously, MicroShift deployed the internal build of topolvm. The last commit where this was the case is 68437d7. We'll need to grab the microshift code, manifests, and rebase data files from there.

@eslutsky

eslutsky commented Sep 2, 2024

Copy link
Copy Markdown
Contributor Author

@ggiguash , looks like ovn-kubernetes-microshift in also part of the okd upstream release, so we dont need to replace that.

@eslutsky eslutsky force-pushed the okd-rebase branch 2 times, most recently from 85d1652 to 9455997 Compare September 3, 2024 14:50
@eslutsky

eslutsky commented Sep 3, 2024

Copy link
Copy Markdown
Contributor Author

/test microshift-metal-tests

@eslutsky

eslutsky commented Sep 3, 2024

Copy link
Copy Markdown
Contributor Author

/test microshift-metal-tests

@eslutsky eslutsky force-pushed the okd-rebase branch 2 times, most recently from 40b5352 to a8cfca8 Compare September 6, 2024 08:17
ggiguash
ggiguash reviewed Sep 6, 2024
View reviewed changes
Comment thread packaging/systemd/microshift.service Outdated

@ggiguash ggiguash Sep 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one we cannot merge. It has to be a systemd drop-in, not a rewrite of the existing file

@eslutsky eslutsky Sep 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. lets see how the Flannel PR will handle it, since we already relying on it.

@eslutsky eslutsky changed the title USHIFT-4120: Test only: replace to okd released assets USHIFT-4120: WIP: build runnable microshift-okd bootc container Sep 6, 2024
@eslutsky

eslutsky commented Sep 6, 2024

Copy link
Copy Markdown
Contributor Author

@praveenkumar take a look

@eslutsky eslutsky changed the title USHIFT-4335 USHIFT-4354 USHIFT-4356: WIP: build runnable microshift-okd bootc container USHIFT-4335 USHIFT-4354 USHIFT-4356: build runnable microshift-okd bootc container Sep 18, 2024
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@openshift-ci openshift-ci Bot requested review from ggiguash and pmtk September 18, 2024 09:32
ggiguash
ggiguash reviewed Sep 18, 2024
View reviewed changes
Comment thread okd/src/use_okd_assets.sh Outdated
ggiguash
ggiguash reviewed Sep 18, 2024
View reviewed changes
Comment thread okd/src/use_okd_assets.sh Outdated
ggiguash
ggiguash reviewed Sep 18, 2024
View reviewed changes
Comment thread okd/src/use_okd_assets.sh Outdated
ggiguash
ggiguash reviewed Sep 18, 2024
View reviewed changes
Comment thread okd/src/microshift-okd-multi-build.Containerfile Outdated
ggiguash
ggiguash reviewed Sep 18, 2024
View reviewed changes
Comment thread okd/src/microshift-okd-multi-build.Containerfile Outdated
ggiguash
ggiguash reviewed Sep 18, 2024
View reviewed changes
Comment thread okd/src/microshift-okd-multi-build.Containerfile Outdated
@eslutsky eslutsky force-pushed the okd-rebase branch 7 times, most recently from f1263cb to 5f54cde Compare September 18, 2024 20:43
@eslutsky

eslutsky commented Sep 19, 2024

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-tests-bootc-arm

@eslutsky eslutsky requested a review from ggiguash September 19, 2024 09:28
ggiguash
ggiguash reviewed Sep 19, 2024
View reviewed changes
Comment thread okd/src/use_okd_assets.sh Outdated
Comment on lines 10 to 11

@ggiguash ggiguash Sep 19, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
okd_url=$1
okd_releaseTag=$2
local -r okd_url=$1
local -r okd_releaseTag=$2

Comment thread okd/src/use_okd_assets.sh Outdated
Comment thread okd/src/use_okd_assets.sh Outdated
Comment thread okd/src/use_okd_assets.sh Outdated
Comment thread okd/src/use_okd_assets.sh Outdated
Comment thread okd/src/microshift-okd-multi-build.Containerfile Outdated
@eslutsky
build rpms inside container with multistage build
5364e76 
Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
@ggiguash

ggiguash commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@openshift-ci

openshift-ci Bot commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@eslutsky: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-full-conformance-rhel-eus 0c817b8dedbd183d5e2d53c13d1a632c87109a7e link true /test ocp-full-conformance-rhel-eus
ci/prow/metal-bootc-test-arm f682078700f180a7d523ca9792c92b6db919157d link true /test metal-bootc-test-arm
ci/prow/metal-bootc-test f682078700f180a7d523ca9792c92b6db919157d link true /test metal-bootc-test
ci/prow/microshift-metal-tests f682078700f180a7d523ca9792c92b6db919157d link true /test microshift-metal-tests
ci/prow/microshift-metal-tests-arm f682078700f180a7d523ca9792c92b6db919157d link true /test microshift-metal-tests-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot

openshift-ci-robot commented Sep 19, 2024

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 61281d5 and 2 for PR HEAD 5364e76 in total

@openshift-merge-bot openshift-merge-bot Bot merged commit a329de7 into openshift:main Sep 19, 2024
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request May 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon copejon left review comments

@ggiguash ggiguash ggiguash left review comments

@pacevedom pacevedom Awaiting requested review from pacevedom

@jakobmoellerdev jakobmoellerdev Awaiting requested review from jakobmoellerdev

@pmtk pmtk Awaiting requested review from pmtk

+1 more reviewer

@praveenkumar praveenkumar praveenkumar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ggiguash ggiguash

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@eslutsky @openshift-ci-robot @copejon @jakobmoellerdev @ggiguash @pmtk @praveenkumar @openshift-merge-robot