WIP: Add ipwatch controller to handle IP address changes#564
Closed
mangelajo wants to merge 3 commits into
Closed
Conversation
The IPWatchController will restart MicroShift when IP address changes have been detected. This is an initial implementation which will trigger the initialization of all components with the new IP address and relies on systemd or podman restarting the process. Related-Issue: openshift#556 Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
mangelajo
changed the title
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
This commit updates the openshift-apiserver and openshift-oauth-apiserver when at microshift boot a new IP address is detected or configured. In addition, instead of following what kube-apiserver does with the Endpoints, we just use the IP we want, kube-apiserver could need some time to update endpoints at boot, and does not work well for 127.0.0.1 in our current configuration. Close-Issue: openshift#556 Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
Contributor
|
There already exists a mechanism for shutting down MicroShift and its embedded services, which is to cancel the context, either directly or via a SIGTERM sent to MicroShift. I believe we should reuse that mechanism rather than implementing a new + parallel mechanism. |
Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
mangelajo
force-pushed
the
dynamic-ip-changes
branch
from
d13634e to
fa65a7d
Compare
Contributor
|
Closing this PR in favour of #650 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IPWatchController will restart MicroShift when IP address
changes have been detected.
This is an initial implementation which will trigger the initialization
of all components with the new IP address and relies on systemd or
podman restarting the process.
Related-Issue: #556
Signed-off-by: Miguel Angel Ajo majopela@redhat.com