Skip to content

Pack containers into GitHub CI#615

Merged
oglok merged 2 commits into
openshift:mainfrom
mangelajo:github-container-tars
Mar 7, 2022
Merged

Pack containers into GitHub CI#615
oglok merged 2 commits into
openshift:mainfrom
mangelajo:github-container-tars

Conversation

@mangelajo

@mangelajo mangelajo commented Mar 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

These .tar.gzs later will be used by common non-podman capable builders
(copr) to create rpms with the container images.

Signed-off-by: Miguel Angel Ajo majopela@redhat.com

@openshift-ci openshift-ci Bot requested review from copejon and husky-parul March 4, 2022 16:32
@mangelajo mangelajo force-pushed the github-container-tars branch from abf47eb to c298966 Compare March 7, 2022 14:37
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2022
@mangelajo mangelajo self-assigned this Mar 7, 2022
@mangelajo mangelajo changed the title WIP: pack containers into GitHub CI Pack containers into GitHub CI Mar 7, 2022
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2022
@mangelajo mangelajo force-pushed the github-container-tars branch from c298966 to 5d34c28 Compare March 7, 2022 14:39
@husky-parul

husky-parul commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 7, 2022
mangelajo
mangelajo commented Mar 7, 2022
View reviewed changes
Comment thread scripts/release.sh Outdated
@mangelajo mangelajo force-pushed the github-container-tars branch from 5d34c28 to 592e4bf Compare March 7, 2022 16:46
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
@mangelajo
Pack containers during GitHub CI release.sh
592e4bf 
These .tar.gzs can be later used by common non-podman capable builders
(copr) to create rpms with the container images.

Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
@copejon

copejon commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

/retest

copejon
copejon reviewed Mar 7, 2022
View reviewed changes
Comment thread Makefile Outdated
# container image packaging #
###############################

image-tars:

@copejon copejon Mar 7, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little vague. Could we name it something more descriptive of it's purpose, i.e. package-ocp-images or something.

@mangelajo mangelajo Mar 7, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I used tar-ocp-containers since package is something we may want to use for a final rpm.

@copejon

copejon commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
@copejon

copejon commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

openshift-ci is having some internal difficulties. will re-run once it's stable again.

@openshift-ci

openshift-ci Bot commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

@mangelajo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-arch 65c82ad link false /test e2e-openshift-conformance-sig-arch
ci/prow/e2e-openshift-conformance-sig-node 65c82ad link false /test e2e-openshift-conformance-sig-node
ci/prow/e2e-openshift-conformance-sig-instrumentation 65c82ad link false /test e2e-openshift-conformance-sig-instrumentation
ci/prow/e2e-openshift-conformance-sig-cli 65c82ad link false /test e2e-openshift-conformance-sig-cli
ci/prow/e2e-openshift-conformance-sig-apps 65c82ad link false /test e2e-openshift-conformance-sig-apps
ci/prow/e2e-openshift-conformance-sig-api-machinery 65c82ad link false /test e2e-openshift-conformance-sig-api-machinery

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oglok

oglok commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

/approve prow issues are unrelated to this patch

@openshift-ci

openshift-ci Bot commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, husky-parul, oglok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [copejon,husky-parul,oglok]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oglok oglok merged commit 58acf59 into openshift:main Mar 7, 2022
@mangelajo mangelajo mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon copejon left review comments

@husky-parul husky-parul Awaiting requested review from husky-parul

Assignees

@mangelajo mangelajo

@copejon copejon

@husky-parul husky-parul

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mangelajo @husky-parul @copejon @oglok