Equalise service stop or failures#637
Conversation
mangelajo
added
the
do-not-merge/work-in-progress
mangelajo
removed
the
do-not-merge/work-in-progress
The kube-proxy k8s code does not support an stop channel, but at least we can accept cancel on the context and move on, so MicroShift can be stopped properly when necessary. Related-Issue: openshift#556 Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
This normalizes the kustomization service with the other services, and makes kustomization issues evident to the deployer. Signed-off-by: Miguel Angel Ajo Pelayo <miguelangel@ajo.es>
|
/retest |
There was a problem hiding this comment.
Why create and pass in a new stop channel here, shouldn't this be ctx.Done()?
There was a problem hiding this comment.
Same reason, this api server does not receive any context anywhere,
There was a problem hiding this comment.
Sorry, I didn't fully understood your comment, moving to ctx.Done() which I remember doing and not working (channel directionality(, but it works.
There was a problem hiding this comment.
Why create and pass in a new stop channel here, shouldn't this be ctx.Done()?
There was a problem hiding this comment.
As much as I looked I didn0t find the openshift-apiserver receiving the context in any form, so we can't cancel it that way. They use a stop channel. Hopefully this would change in a future.
There was a problem hiding this comment.
That's why I wait for the context, outside, and propagate down to the stop channel.
There was a problem hiding this comment.
As we talked OOB I'm extracting the stop channel with ctx.Done() for simpler code.
|
/retest |
Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
|
This one should be good now. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oglok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
4 participants
This PR handles service stop/failure to make them all behave equally, and also to be able
to be stopped on request, please see individual commits.