Skip to content

USHIFT-5476: [release-4.18] Fix bug: fix certificate rotation test time mismatch#6443

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
copejon:fix-cert-rotation-4.18
Apr 3, 2026
Merged

USHIFT-5476: [release-4.18] Fix bug: fix certificate rotation test time mismatch#6443
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
copejon:fix-cert-rotation-4.18

Conversation

@copejon

@copejon copejon commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix certificate rotation test that fails due to TLS validation errors when system time is manipulated
  • Replace Wait For MicroShift (runs oc locally) with Wait Until Greenboot Health Check Exited (runs via SSH on remote host)
  • Certificates regenerated with future NotBefore times are now validated using the manipulated time on the remote host

Test plan

  • Run certificate rotation test suite on release-4.18

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f3978552-34ce-41cf-be20-96ff8c283d69

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from ggiguash and pmtk April 1, 2026 22:13
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
@copejon copejon changed the title Fix bug: fix certificate rotation test time mismatch USHIFT-5476: Fix bug: fix certificate rotation test time mismatch Apr 1, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2026
@openshift-ci-robot

openshift-ci-robot commented Apr 1, 2026

Copy link
Copy Markdown

@copejon: This pull request references USHIFT-5476 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.z" version, but no target version was set.

Details

In response to this:

Summary

  • Fix certificate rotation test that fails due to TLS validation errors when system time is manipulated
  • Replace Wait For MicroShift (runs oc locally) with Wait Until Greenboot Health Check Exited (runs via SSH on remote host)
  • Certificates regenerated with future NotBefore times are now validated using the manipulated time on the remote host

Test plan

  • Run certificate rotation test suite on release-4.18

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@copejon copejon changed the title USHIFT-5476: Fix bug: fix certificate rotation test time mismatch USHIFT-5476: [release-4.18] Fix bug: fix certificate rotation test time mismatch Apr 1, 2026
@copejon

copejon commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 1, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@copejon: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

All Certificates Should Be Valid For Current Time
Setup Kubeconfig
Wait For MicroShift
Wait Until Greenboot Health Check Exited

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Wait Until Greenboot Health Check Exited keyword will likely exit immediately because the procedure does not change anything for greenboot.
If the intention is to wait for something, we should use Restart Greenboot And Wait For Success instead.

The certificate rotation test changes system time on the remote MicroShift host, but Wait For MicroShift runs oc commands locally on the test runner where time hasn't changed. This causes TLS validation to fail because regenerated certificates have NotBefore set to the future time. Use Wait For MicroShift Healthcheck Success instead, which runs via SSH on the remote host using the manipulated time.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@copejon copejon force-pushed the fix-cert-rotation-4.18 branch from 4ec5f89 to e55e7a2 Compare April 2, 2026 14:53
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Apr 2, 2026
@ggiguash

ggiguash commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2026
@openshift-ci

openshift-ci Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@copejon

copejon commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-tests
/test e2e-aws-tests-bootc-arm

1 similar comment
@copejon

copejon commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-tests
/test e2e-aws-tests-bootc-arm

@ggiguash

ggiguash commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed
/label jira/valid-bug
/verified by ci

@openshift-ci openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 3, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/label backport-risk-assessed
/label jira/valid-bug
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4f9a94a and 2 for PR HEAD e55e7a2 in total

@openshift-ci

openshift-ci Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

@copejon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 4a49807 into openshift:release-4.18 Apr 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants