Skip to content

Build container rpms from docker repositories#645

Merged
mangelajo merged 2 commits into
openshift:mainfrom
mangelajo:rpm-images-from-github
Apr 20, 2022
Merged

Build container rpms from docker repositories#645
mangelajo merged 2 commits into
openshift:mainfrom
mangelajo:rpm-images-from-github

Conversation

@mangelajo

@mangelajo mangelajo commented Apr 1, 2022

Copy link
Copy Markdown
Contributor

This will ease integration on build systems like copr, those
build systems build as a non privileged user where podman pull --root
won't work.

Also, this packs a tarball file in the rpm which is extracted during
the post phase to avoid additional limitations of the build systems
removing the tarball uid/gids of the files. Also cpio storage
in the rpm will save all as root/root unless explicitly told otherwise
via %files directives.

Which issue(s) this PR addresses:

Closes #162

Co-Authored-By: Brent Salisbury bsalisbu@redhat.com

@openshift-ci openshift-ci Bot requested review from copejon and rootfs April 1, 2022 11:05
@mangelajo mangelajo force-pushed the rpm-images-from-github branch from d06f119 to 70be388 Compare April 8, 2022 14:21
Comment thread packaging/rpm/make-microshift-images-rpm.sh Outdated
@mangelajo mangelajo force-pushed the rpm-images-from-github branch from 70be388 to e274035 Compare April 8, 2022 17:44
@mangelajo mangelajo changed the title Build container rpms from github tarballs Build container rpms from docker repositories Apr 8, 2022
@mangelajo mangelajo added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2022
@mangelajo mangelajo force-pushed the rpm-images-from-github branch from e274035 to 5d1419a Compare April 11, 2022 18:27
@mangelajo mangelajo removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2022
@mangelajo mangelajo requested a review from fzdarsky April 11, 2022 18:27
@mangelajo mangelajo force-pushed the rpm-images-from-github branch 2 times, most recently from 82d8ad2 to adc7d13 Compare April 12, 2022 09:28
@mangelajo

Copy link
Copy Markdown
Contributor Author

rebased on main

This will ease integration on build systems like copr, those
build systems build as a non privileged user where podman pull --root
won't work.

This introduces paack.py and a yaml format to pack images.

Co-Authored-By: Brent Salisbury <bsalisbu@redhat.com>ââ
@mangelajo

Copy link
Copy Markdown
Contributor Author

/test

@openshift-ci

openshift-ci Bot commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

@mangelajo: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test test-srpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-openshift-conformance-sig-api-machinery
  • /test e2e-openshift-conformance-sig-apps
  • /test e2e-openshift-conformance-sig-arch
  • /test e2e-openshift-conformance-sig-auth
  • /test e2e-openshift-conformance-sig-cli
  • /test e2e-openshift-conformance-sig-instrumentation
  • /test e2e-openshift-conformance-sig-network
  • /test e2e-openshift-conformance-sig-node
  • /test e2e-openshift-conformance-sig-scheduling
  • /test e2e-openshift-conformance-sig-storage
  • /test e2e-reboot
  • /test e2e-rpm-install

Use /test all to run all jobs.

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mangelajo

Copy link
Copy Markdown
Contributor Author

/retest

@mangelajo mangelajo requested a review from oglok April 13, 2022 14:41

@oglok oglok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Just a nit

Comment thread packaging/rpm/paack.py Outdated
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@openshift-ci

openshift-ci Bot commented Apr 19, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oglok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
Co-authored-by: Ricardo Noriega De Soto <rnoriega@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@openshift-ci

openshift-ci Bot commented Apr 19, 2022

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@mangelajo mangelajo merged commit a4d5576 into openshift:main Apr 20, 2022
@mangelajo mangelajo mentioned this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pre-loading container images into CRI-O

3 participants