Skip to content

USHIFT-6847: MicroShift CI doctor command and script cleanup#6514

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
ggiguash:ci-doctor-removal
Apr 16, 2026
Merged

USHIFT-6847: MicroShift CI doctor command and script cleanup#6514
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
ggiguash:ci-doctor-removal

Conversation

@ggiguash

@ggiguash ggiguash commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

The utility has been migrated to https://github.com/openshift-eng/edge-tooling/tree/main/plugins/microshift-ci.

This PR can only merge after openshift/release#77676.

/hold

Summary by CodeRabbit

  • Chores
    • Removed internal continuous integration analysis infrastructure, including diagnostic command definitions and associated automation scripts.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 16, 2026
@openshift-ci-robot

openshift-ci-robot commented Apr 16, 2026

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-6847 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

The utility has been migrated to https://github.com/openshift-eng/edge-tooling/tree/main/plugins/microshift-ci.

This PR can only merge after openshift/release#77676.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2026
@coderabbitai

coderabbitai Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: df5ac228-7243-472c-835c-10f228f1cafe

📥 Commits

Reviewing files that changed from the base of the PR and between 83a538a and 4d0a00f.

📒 Files selected for processing (14)
  • .claude/commands/analyze-ci/create-bugs.md
  • .claude/commands/analyze-ci/doctor.md
  • .claude/commands/analyze-ci/prow-job.md
  • .claude/commands/analyze-ci/test-job.md
  • .claude/commands/analyze-ci/test-scenario.md
  • .claude/scripts/analyze-ci-aggregate.py
  • .claude/scripts/analyze-ci-create-report.py
  • .claude/scripts/analyze-ci-doctor.sh
  • .claude/scripts/analyze-ci-download-jobs.sh
  • .claude/scripts/analyze-ci-search-bugs.py
  • .claude/scripts/extract_microshift_version.py
  • .claude/scripts/microshift-prow-jobs-for-pull-requests.sh
  • .claude/scripts/microshift-prow-jobs-for-release.sh
  • .claude/settings.json
💤 Files with no reviewable changes (13)
  • .claude/commands/analyze-ci/test-job.md
  • .claude/commands/analyze-ci/create-bugs.md
  • .claude/commands/analyze-ci/test-scenario.md
  • .claude/commands/analyze-ci/doctor.md
  • .claude/scripts/analyze-ci-download-jobs.sh
  • .claude/commands/analyze-ci/prow-job.md
  • .claude/scripts/microshift-prow-jobs-for-release.sh
  • .claude/scripts/microshift-prow-jobs-for-pull-requests.sh
  • .claude/scripts/analyze-ci-search-bugs.py
  • .claude/scripts/analyze-ci-doctor.sh
  • .claude/scripts/analyze-ci-aggregate.py
  • .claude/scripts/extract_microshift_version.py
  • .claude/scripts/analyze-ci-create-report.py

Walkthrough

This PR removes the entire CI analysis subsystem, including five command documentation files, six Python/Bash analysis and reporting scripts, two job-query utilities, and related configuration permissions. The deleted infrastructure previously supported analyzing Prow CI failures, aggregating job data, searching bugs, and generating reports.

Changes

Cohort / File(s) Summary
Command Documentation
.claude/commands/analyze-ci/create-bugs.md, .../doctor.md, .../prow-job.md, .../test-job.md, .../test-scenario.md
Removed specifications and usage documentation for five /analyze-ci commands covering bug creation, job analysis, testing, and reporting workflows.
Analysis & Aggregation Scripts
.claude/scripts/analyze-ci-aggregate.py, analyze-ci-search-bugs.py, extract_microshift_version.py
Removed Python utilities for clustering CI job failures, extracting structured summaries, similarity-based grouping, and MicroShift version extraction from CI artifacts.
Report & Orchestration Scripts
.claude/scripts/analyze-ci-create-report.py, analyze-ci-doctor.sh, analyze-ci-download-jobs.sh
Removed HTML report generation, doctor command orchestration (prepare/finalize phases), and GCS artifact download infrastructure.
Job Query Utilities
.claude/scripts/microshift-prow-jobs-for-release.sh, microshift-prow-jobs-for-pull-requests.sh
Removed Bash scripts for querying Prow dataset, filtering MicroShift jobs by release/PR, and reporting job status summaries.
Configuration
.claude/settings.json
Removed allowed shell command permissions (curl, jq, gh) and skill registrations for analyze-ci:create-bugs, analyze-ci:prow-job, analyze-ci:doctor.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removal of the in-repo CI doctor command and associated scripts that were migrated to edge-tooling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR removes CI doctor utilities without modifying Ginkgo tests, making the Ginkgo test name stability check not applicable.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test code quality is not applicable as this PR contains no Ginkgo test files.
Microshift Test Compatibility ✅ Passed PR removes CI infrastructure code; no new Ginkgo e2e tests added, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR removes CI doctor utility files as part of migration to separate repository. No new Ginkgo e2e tests added, so SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only removes CI/automation scripts and documentation in .claude/ directory; no deployment manifests, operator code, or Kubernetes scheduling constraints modified.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check is not applicable to this PR. The PR removes CI doctor documentation files (.md files in .claude/commands/), utility scripts (Python/Bash files in .claude/scripts/), and updates .claude/settings.json. These changes do not involve any Go binaries, test code, or process-level code that could violate the OTE stdout protocol.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR removes CI doctor utility scripts and documentation from .claude/ directory as part of migration to external repository. No new Ginkgo e2e tests added, so custom check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot

openshift-ci-robot commented Apr 16, 2026

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-6847 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

The utility has been migrated to https://github.com/openshift-eng/edge-tooling/tree/main/plugins/microshift-ci.

This PR can only merge after openshift/release#77676.

/hold

Summary by CodeRabbit

  • Chores
  • Removed internal continuous integration analysis infrastructure, including diagnostic command definitions and associated automation scripts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from agullon and eslutsky April 16, 2026 12:23
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2026
@ggiguash

Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2026
@ggiguash

Copy link
Copy Markdown
Contributor Author

/verified by @ggiguash

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 16, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@ggiguash: This PR has been marked as verified by @ggiguash.

Details

In response to this:

/verified by @ggiguash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk

pmtk commented Apr 16, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2026
@openshift-ci

openshift-ci Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 3134ee1 into openshift:main Apr 16, 2026
7 checks passed
@ggiguash ggiguash deleted the ci-doctor-removal branch April 26, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants