[release-4.22] USHIFT-6905: consolidate CI test scenarios to reduce VM count#6588
Conversation
|
@agullon: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/test e2e-aws-tests-release |
1 similar comment
|
/test e2e-aws-tests-release |
TLS v1.3 enforcement is a transport-layer concern validated by multi-config-standard1 which already applies TLS v1.3 and runs standard1 tests. Dedicated TLS v1.3 scenarios for standard1/standard2 are redundant. Also remove --exclude version from multi-config-standard1 so that version tests now run there, and drop the stale comment that referenced the old exclusion. Removes 6 VMs (2 per platform: el9/el10 bootc, ostree). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Piggyback the configuration test suite onto the dual-stack VM which is already provisioned with a compatible environment. The dual-stack scenario is renamed to dual-stack-configuration to reflect the combined coverage. Removes 3 VMs (1 per platform: el9/el10 bootc, ostree). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Consolidate the FIPS test suite into the ai-model-serving-online VM by switching to the FIPS image, adding --fips to launch_vm for kernel-level FIPS enforcement, and appending suites/fips/ to the test run. Both scenarios already skip on aarch64. Removes 2 VMs (1 per platform: el9/el10 bootc; no ostree equivalent). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Merge the standalone upgrade+standard1/standard2 scenarios into the LVMS upgrade scenarios. Each LVMS VM now runs the full LVMS lifecycle (create/check/upgrade/validate/cleanup) followed by a standard suite, eliminating the need for separate standard-only VMs. The split follows a consistent pattern across el9/el10 bootc and ostree: - lvms-standard1: LVMS lifecycle + ginkgo (y2 only) + standard1 with EXPECTED_OS_VERSION + --vm_disksize 30 - lvms-standard2: LVMS lifecycle + standard2 + --vm_disksize 30 For el10, the el98→el102 cross-major upgrade scenarios also absorb LVMS lifecycle testing with --vm_disksize 30. Removes 12 VMs (4 per platform: el9/el10 bootc, ostree) and absorbs the el10 el98→el102 LVMS scenario into the standard1/standard2 cross-major scenarios. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Remove the .disabled suffix from el98 RPM standard1, standard2, and upgrade scenarios to restore their execution in CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Change set -ux to set -eux so that cleanup failures (API server unreachable, RBAC errors, etc.) abort the scenario instead of silently exiting 0 and letting subsequent standard suite tests run on a degraded cluster. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
3bcb155 to
7011295
Compare
|
/test e2e-aws-tests-release |
The tuned image overwrites /etc/tuned/microshift-baseline-variables.conf with test-specific values, causing rpm -V --configfiles to fail in the version.robot RPM integrity check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
|
/test e2e-aws-tests-release |
|
@agullon: This pull request references USHIFT-6905 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/retest all |
|
|
/test e2e-aws-tests-release |
|
/test e2e-aws-tests-bootc-release-arm-el9 |
|
/override ci/prow/e2e-aws-tests-bootc-release-arm-el9 because errors no related with this change |
|
@agullon: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-tests-bootc-release-el10 |
|
@agullon: Overrode contexts on behalf of agullon: ci/prow/e2e-aws-tests-bootc-release-el10 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label jira/valid-bug |
|
@agullon: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@agullon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/e2e-aws-tests-bootc-release-arm-el10 |
|
@agullon: Overrode contexts on behalf of agullon: ci/prow/e2e-aws-tests-bootc-release-arm-el10, ci/prow/e2e-aws-tests-bootc-release-arm-el9 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@agullon: This pull request references USHIFT-6905 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. Retaining the jira/valid-bug label as it was manually added. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest |
|
/override ci/prow/e2e-aws-tests-bootc-release-arm-el10 these failures will be addressed here: https://redhat.atlassian.net/browse/USHIFT-6887 |
|
@agullon: Overrode contexts on behalf of agullon: ci/prow/e2e-aws-tests-bootc-release-arm-el10, ci/prow/e2e-aws-tests-bootc-release-el10 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@agullon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
b4429ec
into
openshift:release-4.22
This is a cherrypick from #6591
Summary
Consolidate CI test scenarios to reduce VM count without losing test coverage. Tests that ran in dedicated VMs are now piggy-backed onto VMs already provisioned for compatible environments.
The changes are symmetric across el9 and el10 for the y1/y2 upgrade paths and standalone scenarios. el10 has additional operations for the el98→el102 cross-major-version upgrade path which has no el9 equivalent.
Additionally,
cleanupWorkload.shis fixed to useset -eux(wasset -ux) so that cleanup failures abort the scenario instead of silently continuing.test/scenarios-bootc/el9/releases/(8 deleted, 4 renamed, 2 created, 1 modified → net -6 VMs)Deleted (8):
el98-lrel@tlsv13-standard1.sh— TLS v1.3 + standard1 already covered bymulti-config-standard1el98-lrel@tlsv13-standard2.sh— TLS v1.3 enforcement is transport-layer; validated bymulti-config-standard1running standard1, so dedicated standard2+TLS v1.3 testing is redundantel98-lrel@configuration.sh— configuration suite moved intodual-stack-configurationel98-lrel@fips.sh— FIPS suite moved intoai-model-serving-online-fipsel96-y1@el98-lrel@standard1.sh— standard1 suite moved intoel96-y1@lvms-standard1el96-y1@el98-lrel@standard2.sh— standard2 suite moved intoel96-y1@lvms-standard2el96-y2@el98-lrel@standard1.sh— standard1 suite moved intoel96-y2@lvms-standard1el96-y2@el98-lrel@standard2.sh— standard2 suite moved intoel96-y2@lvms-standard2Renamed (4):
el98-lrel@dual-stack.sh→el98-lrel@dual-stack-configuration.sh— addedsuites/configuration/el98-lrel@ai-model-serving-online.sh→el98-lrel@ai-model-serving-online-fips.sh— switched tofipsimage, added--fipstolaunch_vm, addedsuites/fips/el96-y1@el98-lrel@lvms.sh→el96-y1@el98-lrel@lvms-standard1.sh— added--vm_disksize 30el96-y2@el98-lrel@lvms.sh→el96-y2@el98-lrel@lvms-standard2.sh— removed ginkgo, addedsuites/standard2/after LVMS cleanupCreated (2):
el96-y1@el98-lrel@lvms-standard2.sh— LVMS lifecycle + standard2 after upgrade (replaces deleted standard2)el96-y2@el98-lrel@lvms-standard1.sh— LVMS lifecycle + ginkgo + standard1 after upgrade (replaces deleted standard1)Modified (1):
el98-lrel@multi-config-standard1.sh— removed--exclude versionand stale comment (now the only place running standard1 with TLS v1.3)test/scenarios-bootc/el10/releases/(8 deleted, 5 renamed, 1 created, 3 modified → net -7 VMs)Same as el9 for standalone and y1/y2 upgrade scenarios, plus additional changes for the el98→el102 cross-major-version upgrade path (no el9 equivalent).
Deleted (8):
el102-lrel@tlsv13-standard1.sh— TLS v1.3 + standard1 already covered bymulti-config-standard1el102-lrel@tlsv13-standard2.sh— TLS v1.3 enforcement is transport-layer; validated bymulti-config-standard1running standard1, so dedicated standard2+TLS v1.3 testing is redundantel102-lrel@configuration.sh— configuration suite moved intodual-stack-configurationel102-lrel@fips.sh— FIPS suite moved intoai-model-serving-online-fipsel96-y1@el102-lrel@standard1.sh— standard1 suite moved into upgrade LVMS scenariosel96-y1@el102-lrel@standard2.sh— standard2 suite moved into upgrade LVMS scenariosel96-y2@el102-lrel@standard1.sh— standard1 suite moved intoel96-y2@lvms-standard1el96-y2@el102-lrel@standard2.sh— standard2 suite moved intoel96-y2@lvms-standard2Renamed (4 + 1 el98→el102):
el102-lrel@dual-stack.sh→el102-lrel@dual-stack-configuration.sh— addedsuites/configuration/el102-lrel@ai-model-serving-online.sh→el102-lrel@ai-model-serving-online-fips.sh— switched tofipsimage, added--fipstolaunch_vm, addedsuites/fips/el96-y1@el102-lrel@lvms.sh→el96-y1@el102-lrel@lvms-standard1.sh— added--vm_disksize 30el96-y2@el102-lrel@lvms.sh→el96-y2@el102-lrel@lvms-standard1.sh— added--vm_disksize 30el98-lrel@el102-lrel@lvms.sh→el96-y1@el102-lrel@lvms-standard2.sh— changed upgrade path from el98→el102 to el96-y1→el102, removed ginkgo, added standard2, added--vm_disksize 30(el98 LVMS tests absorbed into modifiedel98-lrel@el102-lrel@standard1/2)Created (1):
el96-y2@el102-lrel@lvms-standard2.sh— LVMS lifecycle + standard2 after upgradeModified (1 + 2 el98→el102):
el102-lrel@multi-config-standard1.sh— removed--exclude versionand stale commentel98-lrel@el102-lrel@standard1.sh— expanded with LVMS lifecycle (create/check/upgrade/validate/cleanup) +--vm_disksize 30, absorbing oldel98-lrel@el102-lrel@lvms.shel98-lrel@el102-lrel@standard2.sh— expanded with LVMS lifecycle (create/check/upgrade/validate/cleanup) +--vm_disksize 30, absorbing oldel98-lrel@el102-lrel@lvms.shtest/scenarios/releases/(ostree) (7 deleted, 3 renamed, 2 created, 3 re-enabled → net -2 VMs)Equivalent to el9 bootc changes (no FIPS or AI model serving scenarios in ostree).
Deleted (7):
el98-lrel@tlsv13-standard1.sh— TLS v1.3 + standard1 already covered byginkgo-multi-configel98-lrel@tlsv13-standard2.sh— TLS v1.3 enforcement is transport-layer; validated byginkgo-multi-configrunning standard1, so dedicated standard2+TLS v1.3 testing is redundantel98-lrel@configuration.sh— configuration suite moved intodual-stack-configurationel96-yminus1@el98-lrel@standard1.sh— standard1 suite moved intoyminus1@lvms-standard1el96-yminus1@el98-lrel@standard2.sh— standard2 suite moved intoyminus1@lvms-standard2el96-yminus2@el98-lrel@standard1.sh— standard1 suite moved intoyminus2@lvms-standard1el96-yminus2@el98-lrel@standard2.sh— standard2 suite moved intoyminus2@lvms-standard2Renamed (3):
el98-lrel@dual-stack.sh→el98-lrel@dual-stack-configuration.sh— addedsuites/configuration/el96-yminus1@el98-lrel@lvms.sh→el96-yminus1@el98-lrel@lvms-standard1.sh— added--vm_disksize 30el96-yminus2@el98-lrel@lvms.sh→el96-yminus2@el98-lrel@lvms-standard2.sh— removed ginkgo, addedsuites/standard2/after LVMS cleanup, added--vm_disksize 30Created (2):
el96-yminus1@el98-lrel@lvms-standard2.sh— LVMS lifecycle + standard2 after upgradeel96-yminus2@el98-lrel@lvms-standard1.sh— LVMS lifecycle + ginkgo + standard1 after upgradeRe-enabled (3):
el98@rpm-standard1.sh(was.disabled)el98@rpm-standard2.sh(was.disabled)el98@rpm-upgrade.sh(was.disabled)scripts/lvms-helpers/(1 modified)cleanupWorkload.sh— changedset -uxtoset -euxso cleanup failures abort the scenarioTotal: 23 scenarios deleted, 12 renamed, 5 created, 3 re-enabled, 1 script fixed → net -15 VMs
Test plan
🤖 Generated with Claude Code