Skip to content

USHIFT-6917: Migrate claude skills to edge tooling#6602

Merged
openshift-merge-bot[bot] merged 4 commits into
openshift:mainfrom
ggiguash:migrate-claude-skills-to-edge-tooling
Apr 29, 2026
Merged

USHIFT-6917: Migrate claude skills to edge tooling#6602
openshift-merge-bot[bot] merged 4 commits into
openshift:mainfrom
ggiguash:migrate-claude-skills-to-edge-tooling

Conversation

@ggiguash

@ggiguash ggiguash commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Related to openshift-eng/edge-tooling#104

Summary by CodeRabbit

  • Documentation

    • Added a new setup guide for installing Claude Code plugins for MicroShift development.
    • Removed documentation for several Claude commands and agents.
  • Chores

    • Updated security permissions to remove web fetch access from a specific service.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2026
@openshift-ci-robot

openshift-ci-robot commented Apr 29, 2026

Copy link
Copy Markdown

@ggiguash: This pull request references USHIFT-6917 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from copejon and vanhalenar April 29, 2026 07:19
@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Reorganizes Claude Code plugin documentation by adding a .claude/README.md installation guide, deleting multiple agent/command specifications, and removing a WebFetch permission from settings.

Changes

Cohort / File(s) Summary
Claude Documentation Consolidation
.claude/agents/microshift-add-enhancement.md, .claude/commands/analyze-microshift-start.md, .claude/commands/analyze-sos-report.md, .claude/commands/generate-tests-template.md, .claude/commands/generate-tests.md, .claude/commands/microshift-release-versions.md, apiserver-config-flow.md
Removed detailed specifications for Claude agents and commands, including workflows for enhancement creation, SOS analysis, test generation, and release version tracking.
Plugin Setup & Configuration
.claude/README.md, .claude/settings.json
Added new README with plugin installation instructions and removed WebFetch permission for prow.ci.openshift.org.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: migrating Claude skills/documentation to edge tooling, as evidenced by deletions of .claude/ files and addition of README with plugin installation guidance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only documentation and configuration changes with no test code modifications.
Test Structure And Quality ✅ Passed The custom check is not applicable to this pull request. The PR consists entirely of documentation and configuration file changes with no Ginkgo test files being added or modified.
Microshift Test Compatibility ✅ Passed PR contains only documentation and configuration file changes in .claude/ directory with no new Ginkgo e2e test files added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only documentation and configuration files without adding new Ginkgo e2e test code, making SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only documentation and configuration files; no deployment manifests, operator code, or controllers are present.
Ote Binary Stdout Contract ✅ Passed PR modifies only documentation and configuration files (.md, .json); no Go code changes affecting stdout operations in process-level entry points.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only documentation and configuration files; no new Ginkgo e2e tests added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.claude/README.md (1)

11-13: Add fenced code block languages to satisfy markdownlint (MD040).

Please annotate both blocks (e.g., bash) to clear lint warnings.

Proposed diff
-```
+```bash
 /plugin marketplace add openshift-eng/edge-tooling

@@
- +bash
/plugin install microshift-ci
/plugin install microshift-dev
/plugin install microshift-release

Also applies to: 17-21

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.claude/README.md around lines 11 - 13, The markdown fenced code blocks
containing the commands (the block with "/plugin marketplace add
openshift-eng/edge-tooling" and the block with the three "/plugin install ..."
lines) are missing a language tag and trigger MD040; update both opening fences
to include a language identifier (e.g., change "```" to "```bash") so each block
is annotated as bash and satisfy markdownlint rules.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.claude/README.md:
- Around line 11-13: The markdown fenced code blocks containing the commands
(the block with "/plugin marketplace add openshift-eng/edge-tooling" and the
block with the three "/plugin install ..." lines) are missing a language tag and
trigger MD040; update both opening fences to include a language identifier
(e.g., change "```" to "```bash") so each block is annotated as bash and satisfy
markdownlint rules.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fc2b3e18-322e-4381-bde5-c814b064a089

📥 Commits

Reviewing files that changed from the base of the PR and between c8024ef and 9144411.

⛔ Files ignored due to path filters (1)
  • rebase.log is excluded by !**/*.log
📒 Files selected for processing (9)
  • .claude/README.md
  • .claude/agents/microshift-add-enhancement.md
  • .claude/commands/analyze-microshift-start.md
  • .claude/commands/analyze-sos-report.md
  • .claude/commands/generate-tests-template.md
  • .claude/commands/generate-tests.md
  • .claude/commands/microshift-release-versions.md
  • .claude/settings.json
  • apiserver-config-flow.md
💤 Files with no reviewable changes (7)
  • .claude/commands/generate-tests-template.md
  • .claude/commands/analyze-sos-report.md
  • .claude/commands/analyze-microshift-start.md
  • apiserver-config-flow.md
  • .claude/commands/microshift-release-versions.md
  • .claude/agents/microshift-add-enhancement.md
  • .claude/commands/generate-tests.md

@openshift-ci

openshift-ci Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@agullon

agullon commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2026
@openshift-ci

openshift-ci Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agullon

agullon commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

/verified by @agullon

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 29, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@agullon: This PR has been marked as verified by @agullon.

Details

In response to this:

/verified by @agullon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 55d5a22 into openshift:main Apr 29, 2026
7 checks passed
@ggiguash ggiguash deleted the migrate-claude-skills-to-edge-tooling branch April 29, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants