Skip to content

USHIFT-7020: Service Mesh: change image pull policy to IfNotPresent#6769

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pmtk:svc-mesh-pull-policy/main
May 30, 2026
Merged

USHIFT-7020: Service Mesh: change image pull policy to IfNotPresent#6769
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pmtk:svc-mesh-pull-policy/main

Conversation

@pmtk

@pmtk pmtk commented May 29, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Optimized container image pulling behavior in the service mesh operator for improved deployment efficiency.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2026
@openshift-ci

openshift-ci Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pmtk pmtk marked this pull request as ready for review May 29, 2026 14:16
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2026
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The servicemesh-operator3 Deployment manifest updates the manager container's imagePullPolicy from Always to IfNotPresent, reducing unnecessary image pulls when the image is already present locally.

Changes

ServiceMesh Operator Configuration

Layer / File(s) Summary
Image pull policy configuration
assets/optional/gateway-api/03-servicemesh-operator3_apps_v1_deployment.yaml
The manager container's imagePullPolicy changed from Always to IfNotPresent.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR does not contain Ginkgo tests. Main project uses standard Go testing package, not Ginkgo framework. Check is not applicable.
Test Structure And Quality ✅ Passed PR modifies only a Kubernetes Deployment YAML manifest (imagePullPolicy change), not Ginkgo test code. The check for test quality is not applicable.
Microshift Test Compatibility ✅ Passed PR only modifies YAML deployment configs; no Ginkgo e2e tests are added, so MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies a Kubernetes Deployment YAML file (imagePullPolicy change), not adding any Ginkgo e2e tests. Check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The change modifies only imagePullPolicy, a container image-pulling behavior unrelated to scheduling. No topology-aware scheduling constraints are introduced or modified.
Ote Binary Stdout Contract ✅ Passed PR modifies only a Kubernetes YAML deployment file (imagePullPolicy change); no Go source code changes that could violate OTE stdout contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR; only a Kubernetes Deployment YAML configuration is modified. Check is not applicable.
No-Weak-Crypto ✅ Passed PR only modifies imagePullPolicy in Kubernetes deployment YAML; no cryptographic code or weak crypto usage detected.
Container-Privileges ✅ Passed Manifest contains no privileged: true, hostPID/Network/IPC, SYS_ADMIN capability, or allowPrivilegeEscalation: true; runs as non-root with dropped capabilities.
No-Sensitive-Data-In-Logs ✅ Passed The PR only changes imagePullPolicy in a Kubernetes YAML deployment file with no logging statements that expose sensitive data like passwords, tokens, API keys, or PII.
Title check ✅ Passed The title accurately reflects the main change: updating imagePullPolicy from Always to IfNotPresent in the servicemesh-operator3 Deployment.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jogeo and kasturinarra May 29, 2026 14:17
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2026
@pmtk pmtk changed the title Service Mesh: change image pull policy to IfNotPresent USHIFT-7020: Service Mesh: change image pull policy to IfNotPresent May 29, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 29, 2026
@openshift-ci-robot

openshift-ci-robot commented May 29, 2026

Copy link
Copy Markdown

@pmtk: This pull request references USHIFT-7020 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Optimized container image pulling behavior in the service mesh operator for improved deployment efficiency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@copejon

copejon commented May 29, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2026
@openshift-ci

openshift-ci Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk

pmtk commented May 29, 2026

Copy link
Copy Markdown
Member Author

/retest

@ggiguash

Copy link
Copy Markdown
Contributor

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 3fd3665 into openshift:main May 30, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants