Skip to content

USHIFT-7184: Enforce VMs to use UTC timezone#6828

Merged
ggiguash merged 1 commit into
openshift:mainfrom
pmtk:force-utc-vms/main
Jun 9, 2026
Merged

USHIFT-7184: Enforce VMs to use UTC timezone#6828
ggiguash merged 1 commit into
openshift:mainfrom
pmtk:force-utc-vms/main

Conversation

@pmtk

@pmtk pmtk commented Jun 8, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated system configuration to set the system timezone to UTC.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The kickstart post-system configuration script adds a symlink command that sets the system timezone to UTC by linking /etc/localtime to the UTC zoneinfo file.

Changes

System Timezone Setup

Layer / File(s) Summary
UTC Timezone Symlink Configuration
test/kickstart-templates/includes/post-system.cfg
Post-system configuration adds a command to symlink /etc/localtime to /usr/share/zoneinfo/UTC, ensuring the system timezone is set to UTC during initialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error File contains hardcoded password hash on line 2 for default "redhat" user and KUBECONFIG path references that may expose credentials in logs. Remove or redact hardcoded password hash; use environment variables or secrets management for sensitive credentials instead of embedding in initialization scripts.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only post-system.cfg, a shell configuration file. No Ginkgo tests present; check not applicable.
Test Structure And Quality ✅ Passed PR modifies post-system.cfg, a kickstart configuration file, not Ginkgo test code. No Ginkgo tests are present in this PR to review against test quality requirements.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests added in this PR. Changes are only in kickstart configuration file post-system.cfg, which is infrastructure setup, not test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies a Kickstart VM template configuration file, not Ginkgo e2e tests. Check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies kickstart template system configuration (UTC timezone symlink), not Kubernetes deployment manifests, operator code, or scheduling constraints. Check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR modifies only a Kickstart template for VM timezone setup. OTE Binary Stdout Contract check applies to Go binaries only; this is shell infrastructure code unrelated to OTE.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only a kickstart template configuration file, not a Ginkgo e2e test. Check applies only to new Ginkgo tests.
No-Weak-Crypto ✅ Passed PR modifies a timezone configuration file only; no cryptographic code, weak crypto patterns (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), or secret comparison logic present.
Container-Privileges ✅ Passed PR modifies VM provisioning templates (kickstart), not container/K8s manifests. Custom check for container-privileges is not applicable.
Title check ✅ Passed The title accurately describes the main change: enforcing UTC timezone for VMs by creating a symlink in the kickstart post-system configuration.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from copejon and ggiguash June 8, 2026 14:27
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2026
@pmtk

pmtk commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

/retest

@pmtk pmtk changed the title Enforce VMs to use UTC timezone USHIFT-7184: Enforce VMs to use UTC timezone Jun 9, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 9, 2026

Copy link
Copy Markdown

@pmtk: This pull request references USHIFT-7184 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Updated system configuration to set the system timezone to UTC.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk

pmtk commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

/cherrypick release-4.22 release-4.21 release-4.20 release-4.19 release-4.18 release-4.17 release-4.16

@openshift-cherrypick-robot

Copy link
Copy Markdown

@pmtk: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.22 release-4.21 release-4.20 release-4.19 release-4.18 release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash

ggiguash commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 9, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/lgtm
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash ggiguash merged commit e84e492 into openshift:main Jun 9, 2026
13 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown

@pmtk: new pull request created: #6835

Details

In response to this:

/cherrypick release-4.22 release-4.21 release-4.20 release-4.19 release-4.18 release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants