USHIFT-7186: Propagate cache download error

[pmtk]

bash's if disables the set -e, so if the manage_build_cache.sh download fails, the error is ignored.

Summary by CodeRabbit

• Bug Fixes
  • Improved build cache handling to properly report download status, ensuring build failures are correctly communicated instead of being masked as successful.

[openshift-ci-robot]

@pmtk: This pull request references USHIFT-7186 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

bash's if disables the set -e, so if the manage_build_cache.sh download fails, the error is ignored.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c986ca70-76d7-4359-97d7-2835e478f8aa

📥 Commits

Reviewing files that changed from the base of the PR and between e84e492 and 126ff05.

📒 Files selected for processing (1)

• test/bin/ci_phase_iso_build.sh

---

Walkthrough

The download_build_cache() function now returns the exit status of ./bin/manage_build_cache.sh download instead of always returning 0, allowing callers to receive and respond to download success or failure.

Changes

Build Cache Download Status

Layer / File(s)	Summary
Exit status propagation in download_build_cache test/bin/ci_phase_iso_build.sh	download_build_cache() now returns $? on the success path instead of unconditionally returning 0, propagating the actual exit status of the cache download operation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title directly reflects the main change: propagating cache download errors instead of suppressing them via set -e disabling.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies test/bin/ci_phase_iso_build.sh (bash script), not Ginkgo tests. Custom check for stable Ginkgo test names is not applicable to shell script changes.
Test Structure And Quality	✅ Passed	PR modifies only a bash build script (test/bin/ci_phase_iso_build.sh), not Ginkgo test code. The custom check for Ginkgo test structure is not applicable.
Microshift Test Compatibility	✅ Passed	PR modifies bash CI script, not Ginkgo e2e tests. Custom check is for e2e test compatibility; no Ginkgo tests added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies a bash build script (test/bin/ci_phase_iso_build.sh), not Ginkgo e2e tests. The SNO compatibility check only applies to new Ginkgo test additions, making it inapplicable here.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies a CI test build script (test/bin/ci_phase_iso_build.sh), not deployment manifests, operator code, or controllers. No scheduling constraints or topology-aware changes are introduced.
Ote Binary Stdout Contract	✅ Passed	PR modifies bash CI build script, not an OTE binary or Go test code. OTE stdout contract check applies only to Go test files, not bash CI scripts.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies only test/bin/ci_phase_iso_build.sh (bash script). Custom check applies to Ginkgo e2e tests; no Go test code changes present.
No-Weak-Crypto	✅ Passed	PR contains only bash error handling logic, no weak crypto (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto, or insecure secret comparisons detected.
Container-Privileges	✅ Passed	PR modifies a bash build script (test/bin/ci_phase_iso_build.sh), not container/K8s manifests. The container-privileges check is not applicable to bash scripts.
No-Sensitive-Data-In-Logs	✅ Passed	PR changes only the return value of download_build_cache() for error propagation; no logging of passwords, tokens, API keys, PII, or sensitive data is introduced.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pmtk]

/cherrypick release-4.22 release-4.21 release-4.20 release-4.19 release-4.18 release-4.17 release-4.16

[openshift-cherrypick-robot]

@pmtk: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.22 release-4.21 release-4.20 release-4.19 release-4.18 release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pmtk]

/retest

[pmtk]

/verified by ci

[openshift-ci-robot]

@pmtk: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ggiguash]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ggiguash,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-cherrypick-robot]

@pmtk: new pull request created: #6846

Details

In response to this:

/cherrypick release-4.22 release-4.21 release-4.20 release-4.19 release-4.18 release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.