-
Notifications
You must be signed in to change notification settings - Fork 232
USHIFT-7228: remove virt-manager from VM host dependencies #6887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6d5cc76
627f754
8164af1
5ce7a11
2ed0ed8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ | |
| import os | ||
| import platform | ||
| import re | ||
| import subprocess | ||
| import sys | ||
| import time | ||
| import traceback | ||
|
|
@@ -219,7 +220,13 @@ def extract_container_images(version, repo_spec, outfile, dry_run=False): | |
|
|
||
| # Construct and execute the dnf download command | ||
| dnf_command = ["dnf", "download"] + dnf_options + [f"microshift-release-info-{version}"] | ||
| if common.run_command(dnf_command, dry_run) is not None: | ||
| try: | ||
| result = common.run_command(dnf_command, dry_run) | ||
| except subprocess.CalledProcessError: | ||
| common.print_msg(f"Warning: failed to download release-info for {version} from {repo_spec}, skipping") | ||
| common.popd() | ||
|
Comment on lines
+223
to
+227
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid logging raw
Suggested patch- except subprocess.CalledProcessError:
- common.print_msg(f"Warning: failed to download release-info for {version} from {repo_spec}, skipping")
+ except subprocess.CalledProcessError:
+ repo_label = common.basename(repo_spec) if repo_spec else "<default>"
+ common.print_msg(
+ f"Warning: failed to download release-info for {version} from repo '{repo_label}', skipping"
+ )
common.popd()
returnAs per coding guidelines, 🤖 Prompt for AI AgentsSource: Coding guidelines |
||
| return | ||
| if result is not None: | ||
| images_output = get_container_images(str(image_path), version) | ||
| with open(outfile, "a") as f: | ||
| f.write(images_output.replace(',', '\n')) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align docs with the new host dependency contract.
Line 71 drops
virt-manager, butdocs/user/getting_started.mdstill lists it in the requireddnf installset. Please update docs to avoid conflicting setup guidance between manual and scripted host config.🤖 Prompt for AI Agents