OCPBUGS-73893: Fix unit test failure by updating ruby version to 3.3 by ardaguclu · Pull Request #2184 · openshift/oc

ardaguclu · 2026-01-16T06:14:06Z

It looks like 3.1 tag of ruby image has been removed and causing our unit test perma-failing. This PR updates the ruby image to 3.3 to fix the test.

openshift-ci-robot · 2026-01-16T06:14:10Z

@ardaguclu: This pull request explicitly references no jira issue.

Details

In response to this:

It looks like 3.1 tag of ruby image has been removed and causing our unit test perma-failing. This PR updates the ruby image to 3.3 to fix the test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-01-16T06:14:21Z

Walkthrough

This change updates the repository context directory path in a test case from version 3.1 to version 3.3, modifying the fixture reference used during app generation testing.

Changes

Cohort / File(s)	Summary
Test fixture update `pkg/helpers/newapp/newapptest/newapp_test.go`	ContextDir reference updated from `3.1/test/rack-test-app` to `3.3/test/rack-test-app` in the "app generation using context dir" test case

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 4df0e94 and 4f7cc64.

📒 Files selected for processing (1)

pkg/helpers/newapp/newapptest/newapp_test.go

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

pkg/helpers/newapp/newapptest/newapp_test.go

🔇 Additional comments (1)

pkg/helpers/newapp/newapptest/newapp_test.go (1)

533-533: LGTM!

The update from 3.1 to 3.3 correctly addresses the test failure caused by the removal of the ruby:3.1 image tag.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

pkg/helpers/newapp/newapptest/newapp_test.go (1)
567-609: Consider updating this test case to use 3.3 as well.

If the entire 3.1 directory was removed from the sti-ruby repository, this test passes for the wrong reason — the parent directory doesn't exist rather than the specific subdirectory being missing. To ensure this test validates the intended "missing context dir within a valid version" scenario, update the path to 3.3/test/missing-dir.
Suggested fix
 		{
 			name: "failed app generation using missing context dir",
 			config: &cmd.AppConfig{
 				ComponentInputs: cmd.ComponentInputs{
 					SourceRepositories: []string{"https://github.com/openshift/sti-ruby"},
 				},
 				GenerationInputs: cmd.GenerationInputs{
-					ContextDir: "3.1/test/missing-dir",
+					ContextDir: "3.3/test/missing-dir",
 				},
 				...
 			},
 			...
 			errFn: func(err error) bool {
-				return err.Error() == "supplied context directory '3.1/test/missing-dir' does not exist in 'https://github.com/openshift/sti-ruby'"
+				return err.Error() == "supplied context directory '3.3/test/missing-dir' does not exist in 'https://github.com/openshift/sti-ruby'"
 			},
 		},

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 4df0e94 and 4f7cc64.

📒 Files selected for processing (1)

pkg/helpers/newapp/newapptest/newapp_test.go

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

pkg/helpers/newapp/newapptest/newapp_test.go

🔇 Additional comments (1)

pkg/helpers/newapp/newapptest/newapp_test.go (1)

533-533: LGTM!

The update from 3.1 to 3.3 correctly addresses the test failure caused by the removal of the ruby:3.1 image tag.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

ardaguclu · 2026-01-16T06:17:30Z

/jira refresh

openshift-ci-robot · 2026-01-16T06:17:30Z

@ardaguclu: This pull request references Jira Issue OCPBUGS-73893, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

It looks like 3.1 tag of ruby image has been removed and causing our unit test perma-failing. This PR updates the ruby image to 3.3 to fix the test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-16T06:17:35Z

@ardaguclu: This pull request references Jira Issue OCPBUGS-73893, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ardaguclu · 2026-01-16T06:18:18Z

/cherrypick release-4.21

openshift-cherrypick-robot · 2026-01-16T06:18:22Z

@ardaguclu: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tchap · 2026-01-16T08:56:42Z

/lgtm

openshift-ci · 2026-01-16T08:57:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ardaguclu · 2026-01-16T09:27:42Z

/verified by CI

ardaguclu · 2026-01-16T09:27:48Z

/retest

openshift-ci-robot · 2026-01-16T09:27:53Z

@ardaguclu: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ardaguclu · 2026-01-16T12:18:14Z

/retest

openshift-ci · 2026-01-16T15:01:44Z

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-01-16T15:05:14Z

@ardaguclu: Jira Issue Verification Checks: Jira Issue OCPBUGS-73893
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-73893 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

It looks like 3.1 tag of ruby image has been removed and causing our unit test perma-failing. This PR updates the ruby image to 3.3 to fix the test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-01-16T15:06:11Z

@ardaguclu: new pull request created: #2186

Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2026-01-19T16:26:52Z

Fix included in accepted release 4.22.0-0.nightly-2026-01-19-085729

Fix unit test failure by updating ruby version to 3.3

4f7cc64

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2026

openshift-ci Bot requested review from adambkaplan and gabemontero January 16, 2026 06:14

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2026

coderabbitai Bot reviewed Jan 16, 2026

View reviewed changes

ardaguclu changed the title ~~NO-JIRA: Fix unit test failure by updating ruby version to 3.3~~ OCPBUGS-73893: Fix unit test failure by updating ruby version to 3.3 Jan 16, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 16, 2026

openshift-ci Bot requested a review from zhouying7780 January 16, 2026 06:17

openshift-ci Bot assigned tchap Jan 16, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 16, 2026

openshift-merge-bot Bot merged commit 430c822 into openshift:main Jan 16, 2026
18 checks passed

openshift-cherrypick-robot mentioned this pull request Jan 16, 2026

[release-4.21] OCPBUGS-73911: Fix unit test failure by updating ruby version to 3.3 #2186

Merged

ardaguclu deleted the fix-unix-test branch January 16, 2026 15:13

MrSanketkumar mentioned this pull request Aug 10, 2026

OCPBUGS-105504,OCPBUGS-105503: Fix pre-existing unit test failures on release-4.19 #2356

Open

Uh oh!

Conversation

ardaguclu commented Jan 16, 2026

Uh oh!

openshift-ci-robot commented Jan 16, 2026

Uh oh!

coderabbitai Bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

ardaguclu commented Jan 16, 2026

Uh oh!

openshift-ci-robot commented Jan 16, 2026

Uh oh!

openshift-ci-robot commented Jan 16, 2026

Uh oh!

ardaguclu commented Jan 16, 2026

Uh oh!

openshift-cherrypick-robot commented Jan 16, 2026

Uh oh!

tchap commented Jan 16, 2026

Uh oh!

openshift-ci Bot commented Jan 16, 2026

Uh oh!

ardaguclu commented Jan 16, 2026

Uh oh!

ardaguclu commented Jan 16, 2026

Uh oh!

openshift-ci-robot commented Jan 16, 2026

Uh oh!

ardaguclu commented Jan 16, 2026

Uh oh!

openshift-ci Bot commented Jan 16, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 16, 2026

Uh oh!

openshift-cherrypick-robot commented Jan 16, 2026

Uh oh!

openshift-merge-robot commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai Bot commented Jan 16, 2026 •

edited

Loading