Remove cmd helper functions

[anandrkskd]

What type of PR is this?

/kind code-refactoring

What does this PR do / why we need it:
This PR will remove old helper functions mentioned below

• CmdShouldRunAndTerminate
• CmdShouldFail
• CmdShouldPass
• CmdShouldFailWithRetry
• CmdShouldRunWithTimeout

Which issue(s) this PR fixes:

Fixes #4517

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

• Update changelog

• I have read the test guidelines

How to test changes / Special notes to the reviewer:

[dharmit]

@anandrkskd can you PTAL if the test failures are related to this PR? I'm inclined to approve & lgtm this but don't want to create an infinite loop.

[dharmit]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• docs/OWNERS [dharmit]
• tests/OWNERS [dharmit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[anandrkskd]

@anandrkskd can you PTAL if the test failures are related to this PR? I'm inclined to approve & lgtm this but don't want to create an infinite loop.

Yeah I am looked into the previous one there was a typo already updated it. looking into k8s failure.

[anandrkskd]

/test v4.7-integration-e2e
/test psi-kubernetes-integration-e2e

[anandrkskd]

prow failure on v4.7-integration-e2e
/test v4.7-integration-e2e

[feloy]

/lgtm