Skip to content

OPRUN-4518: Remove skip for incompatible operator check after rename of CER#690

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
camilamacedo86:enable-test-ote
Apr 1, 2026
Merged

OPRUN-4518: Remove skip for incompatible operator check after rename of CER#690
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
camilamacedo86:enable-test-ote

Conversation

@camilamacedo86
Copy link
Copy Markdown
Contributor

After we get the PR: openshift/cluster-olm-operator#191 merged we can merge this one.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 1, 2026

@camilamacedo86: This pull request references OPRUN-4518 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

After we get the PR: openshift/cluster-olm-operator#191 merged we can merge this one.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bde414fd-a945-4cd8-9050-f6df82aa932a

📥 Commits

Reviewing files that changed from the base of the PR and between 52410d5 and e2f2c30.

📒 Files selected for processing (1)
  • openshift/tests-extension/test/olmv1-incompatible.go
💤 Files with no reviewable changes (1)
  • openshift/tests-extension/test/olmv1-incompatible.go

Walkthrough

Removed the github.com/openshift/api/features import and eliminated a feature-gate conditional that previously skipped test execution when FeatureGateNewOLMBoxCutterRuntime was enabled, allowing the test to proceed unconditionally.

Changes

Cohort / File(s) Summary
Feature Gate Removal
openshift/tests-extension/test/olmv1-incompatible.go
Deleted import of feature gate package and removed conditional skip logic based on FeatureGateNewOLMBoxCutterRuntime, resulting in direct test flow execution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from perdasilva and trgeiger April 1, 2026 05:52
@jianzhangbjz
Copy link
Copy Markdown
Member

Hi @Xia-Zhao-rh , could you help verify it? Thanks!
/assign @Xia-Zhao-rh

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Apr 1, 2026

/hold
Until #691 merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2026
@bandrade
Copy link
Copy Markdown
Contributor

bandrade commented Apr 1, 2026

/label qe-approved
/verified by @bandrade

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 1, 2026

@camilamacedo86: This pull request references OPRUN-4518 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

After we get the PR: openshift/cluster-olm-operator#191 merged we can merge this one.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Apr 1, 2026

/approved

@camilamacedo86
Copy link
Copy Markdown
Contributor Author

/retest-required

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Apr 1, 2026

/unhold
#691 merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2026
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Apr 1, 2026

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit eb20e99 into openshift:main Apr 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants