Skip to content

Update bumper for golang 1.23/OCP 4.19#63

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tmshort:update-ocp
Jan 15, 2025
Merged

Update bumper for golang 1.23/OCP 4.19#63
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tmshort:update-ocp

Conversation

@tmshort
Copy link
Copy Markdown
Contributor

@tmshort tmshort commented Jan 15, 2025

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@grokspawn
Copy link
Copy Markdown
Contributor

grokspawn commented Jan 15, 2025

Do you also want to bump go.mod to 1.23?
It would likely change bingo'd tools' directives like https://github.com/openshift/operator-framework-tooling/pull/63/files#diff-7f392e938b8085f3064be9487ebe3d5f26f33c761ddcf114fa1e305a4f030505R3-R5

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Jan 15, 2025

Those changes are a result of me using golang 1.23.0, so it updated it to 1.22.1, not sure why it picked that version?
The current go.mod file references golang 1.21 (not even 1.22)

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Jan 15, 2025

Lint is passing now, but it might be better to have everything be 1.23?

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Jan 15, 2025

openshift/release has been updated.

Update golangci-lint for 1.23 support

Signed-off-by: Todd Short <todd.short@me.com>
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Jan 15, 2025

The last changed updated go.mod to 1.23... and it removed the toolchain field?

@grokspawn
Copy link
Copy Markdown
Contributor

grokspawn commented Jan 15, 2025

The last changed updated go.mod to 1.23... and it removed the toolchain field?

Yeah & expected. Since you standardized all components on a greatest common version, no toolchain directive was needed anymore.
This is what I was talking about here.

I was expecting the same thing to happen here though. Did you re-gen the bingo config after bumping to go1.23 in go.mod?

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Jan 15, 2025

I tried various things, and it doesn't seem to want to update that to 1.23

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Jan 15, 2025

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jan 15, 2025

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@grokspawn
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e2dc5c4 into openshift:main Jan 15, 2025
@tmshort tmshort deleted the update-ocp branch January 15, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants