-
Notifications
You must be signed in to change notification settings - Fork 4.8k
CNTRLPLANE-2167:Add oc-tests-ext to extension binaries #30653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
/pipeline required |
|
Scheduling required tests: |
|
/retest-required |
|
/retest |
|
/retest/retest-required |
|
/retest-required |
|
/retest |
|
/retest-required |
|
Job Failure Risk Analysis for sha: 866c9d8
|
|
/retest |
pkg/test/extensions/binary.go
Outdated
| binaryPath: "/usr/bin/cluster-version-operator-tests.gz", | ||
| }, | ||
| { | ||
| imageTag: "cli-tests", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gangwgr imageTag needs to be cli?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad i forgot
Add support for extracting and running oc-tests-ext from the cli-tests image in the release payload. Changes: - Add cli-tests image tag to extensionBinaries list - Configure binary path as /usr/bin/oc-tests-ext.gz This enables the test framework to automatically: - Extract oc-tests-ext binary from the cli-tests image - Decompress and execute extension tests - Integrate oc CLI tests with the OpenShift test suite The cli-tests image keeps the test binary separate from the main CLI product image, avoiding size bloat while making tests available for CI.
|
Scheduling required tests: |
|
@gangwgr: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@gangwgr: This pull request references CNTRLPLANE-2167 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by ci runs |
|
@gangwgr: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gangwgr do we expect that current CI jobs run any external test for us to confirm that it works properly. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ardaguclu, gangwgr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
as in current setup we don't have cases in oc repo but we can verify from this https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/30653/pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2/2009280872091488256/artifacts/e2e-aws-ovn-serial/openshift-e2e-test/build-log.txt that our setup works fine, after this we can start moving our case to oc repo from qe repo and we create one job for ote tests if we don't want to create job then our cases will run with openshift conformance suite.
|
|
Adding specific OTE job makes sense to me. Thank you. |
Yes |
|
@gangwgr: This pull request references CNTRLPLANE-2167 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Add support for extracting and running oc-tests-ext from the cli image in the release payload.
Changes:
This enables the test framework to automatically:
The cli image keeps the test binary separate from the main CLI product image, avoiding size bloat while making tests available for CI.