CONSOLE-5188: remove console exceptions

[sg00dwin]

Summary

Remove temporary console exception blocks from legacycvomonitortests/operators.go

Depends on the following PRs:
3 blocks excepted console from Degraded=True failures (OCPBUGS-38676, fixed in console-operator PR #1164)
1 block excepted console from Progressing=True during node reboots (OCPBUGS-64688, fixed in console-operator PR #1169)

Test plan

Package compiles cleanly
go test ./pkg/monitortests/clusterversionoperator/legacycvomonitortests/ passes
OTA invariant tests pass without console exceptions in CI

Assisted-by: Claude (Opus 4.6)

Summary by CodeRabbit

Release Notes

• Tests
  • Strengthened validation of cluster operator state transitions in stable-system and upgrade scenarios.
  • Removed previously permitted exceptions for console availability, degraded, and progressing conditions.
  • Improved detection of unexpected operator health changes during upgrades, including buffered transition windows, helping identify issues more reliably.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@sg00dwin: This pull request references CONSOLE-5188 which is a valid jira issue.

Details

In response to this:

Summary

Remove temporary console exception blocks from legacycvomonitortests/operators.go

Depends on the following PRs:
3 blocks excepted console from Degraded=True failures (OCPBUGS-38676, fixed in console-operator PR #1164)
1 block excepted console from Progressing=True during node reboots (OCPBUGS-64688, fixed in console-operator PR #1169)

Test plan

Package compiles cleanly
go test ./pkg/monitortests/clusterversionoperator/legacycvomonitortests/ passes
OTA invariant tests pass without console exceptions in CI

Assisted-by: Claude (Opus 4.6)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sg00dwin]

/hold

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 91a47955-e832-4376-bf96-4a120197e23e

📥 Commits

Reviewing files that changed from the base of the PR and between c84f750 and 99845ce.

📒 Files selected for processing (1)

• pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

💤 Files with no reviewable changes (1)

• pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

---

Walkthrough

This PR removes console-specific exception whitelists from stable-system, upgrade-state, and upgrade-progressing cluster operator transition tests.

Changes

Console Operator Exception Cleanup

Layer / File(s)	Summary
Stable-system exception validation pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go	Removes console exceptions for insufficient replicas and Degraded=True.
Upgrade-state exception validation pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go	Removes console Degraded=True exceptions from upgrade-window and general operator validation.
Upgrade-progressing exception validation pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go	Removes the console SyncLoopRefresh_InProgress exception.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• openshift/origin#31501: Both PRs modify stable-system console operator transition exceptions.

Suggested reviewers: sjenning, deads2k

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing console exceptions from cluster version operator tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only deletes exception blocks; it adds no Ginkgo declarations or test titles. Existing JUnit names use stable operator and condition identifiers, while node and timestamp data stays in output.
Test Structure And Quality	✅ Passed	The PR changes only non-test operators.go; the package has standard testing Test_* unit tests and no Ginkgo It blocks, cluster resource setup, or Eventually/Consistently calls.
Microshift Test Compatibility	✅ Passed	The patch only removes 18 lines from an existing monitor helper; it adds no files, lines, or Ginkgo test declarations, so the MicroShift test check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit only deletes 18 exception lines from operators.go; it adds no Ginkgo e2e tests or new multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The parent-to-HEAD diff deletes only 18 console exception lines in a monitoring test; it adds no manifests, replicas, affinity, selectors, tolerations, spread constraints, or PDBs.
Ote Binary Stdout Contract	✅ Passed	The patch only deletes 18 exception blocks; it adds no stdout calls, and operators.go has no main/init/suite setup or direct stdout-writing API. fmt.Sprintf builds JUnit strings.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes only one Go file and deletes 18 exception lines; it adds no Ginkgo e2e tests or networking and external-connectivity assumptions.
No-Weak-Crypto	✅ Passed	The PR changes only 18 exception-line deletions in operators.go; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons were added.
Container-Privileges	✅ Passed	The commit changes only 18 deleted lines in a Go test file; it adds no manifests or privilege settings such as privileged, hostPID, hostNetwork, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs	✅ Passed	The commit changes one Go file with 18 deletions and no additions; it introduces no logging or output that could expose sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[sg00dwin]

/retest-required

[sg00dwin]

/retest-required

[sg00dwin]

/unhold

[sg00dwin]

/retest-required

[sg00dwin]

/hold

[sg00dwin]

/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial

[openshift-trt]

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: e446419

Job Name	New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift	High - "Build image origin-devcontainer from the repository" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift	High - "Tag the image origin-devcontainer into the image stream tag stable:origin-devcontainer" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial	High - "Build image origin-devcontainer from the repository" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial	High - "Tag the image origin-devcontainer into the image stream tag stable:origin-devcontainer" is a new test that was not present in all runs against the current commit.

New tests seen in this PR at sha: e446419

• "Build image origin-devcontainer from the repository" [Total: 10, Pass: 10, Fail: 0, Flake: 0]
• "Tag the image origin-devcontainer into the image stream tag stable:origin-devcontainer" [Total: 10, Pass: 10, Fail: 0, Flake: 0]

[sg00dwin]

/hold cancel

[sg00dwin]

Code Approver
/assign @petr-muller

[hongkailiu]

Do you want to remove bug 67134 as well?

origin/pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

Lines 79 to 80 in 8061da4

	if operator == "console" && condition.Reason == "Deployment_InsufficientReplicas" {
	return "https://issues.redhat.com/browse/OCPBUGS-67134"

[sg00dwin]

/test verify

[hongkailiu]

/lgtm

/hold

• wait for 5.1 cut.
• check Sippy stats again before canceling

[hongkailiu]

/test lint

[hongkailiu]

/test verify

[hongkailiu]

/retest-required

[hongkailiu]

/test verify

[hongkailiu]

Likely there is a formatting issue which caused the verify job to fail, e.g., https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/31280/pull-ci-openshift-origin-main-verify/2087151787617292288

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[hongkailiu]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sg00dwin]

/test e2e-gcp-ovn-upgrade

[hongkailiu]

Checked Sippy 5.0 yesterday.
See the comments in the bugs.
They all look good me.

/verified by @hongkailiu

[openshift-ci-robot]

@hongkailiu: This PR has been marked as verified by @hongkailiu.

Details

In response to this:

Checked Sippy 5.0 yesterday.
See the comments in the bugs.
They all look good me.

/verified by @hongkailiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[hongkailiu]

/hold cancel

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.