NE-2750: implement feature test for GatewayAPIManagementMode #31503
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,320 @@ | ||
| package router | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "strings" | ||
| "time" | ||
|
|
||
| g "github.com/onsi/ginkgo/v2" | ||
| o "github.com/onsi/gomega" | ||
|
|
||
| operatorv1alpha1 "github.com/openshift/api/operator/v1alpha1" | ||
|
|
||
| exutil "github.com/openshift/origin/test/extended/util" | ||
|
|
||
| apierrors "k8s.io/apimachinery/pkg/api/errors" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| e2e "k8s.io/kubernetes/test/e2e/framework" | ||
| "k8s.io/kubernetes/test/e2e/upgrades" | ||
| gatewayv1 "sigs.k8s.io/gateway-api/apis/v1" | ||
| ) | ||
|
|
||
| // GatewayAPIManagementModeUpgradeTest verifies that Gateway API management mode | ||
| // transitions work correctly during upgrades and resources remain functional | ||
| type GatewayAPIManagementModeUpgradeTest struct { | ||
| oc *exutil.CLI | ||
| namespace string | ||
| gatewayClassName string | ||
| gatewayName string | ||
| routeName string | ||
| hostname string | ||
| startMode operatorv1alpha1.GatewayAPIManagementMode | ||
| loadBalancerSupported bool | ||
| managedDNS bool | ||
| } | ||
|
|
||
| func (t *GatewayAPIManagementModeUpgradeTest) Name() string { | ||
| return "gateway-api-management-mode-upgrade" | ||
| } | ||
|
|
||
| func (t *GatewayAPIManagementModeUpgradeTest) DisplayName() string { | ||
| return "[sig-network-edge][OCPFeatureGate:GatewayAPIManagementMode][Feature:Router][apigroup:operator.openshift.io] Verify Gateway API management mode transitions during upgrade" | ||
| } | ||
|
|
||
| // Skip checks if this upgrade test should be skipped | ||
| func (t *GatewayAPIManagementModeUpgradeTest) Skip(_ upgrades.UpgradeContext) bool { | ||
| oc := exutil.NewCLIForMonitorTest("gateway-api-mgmt-mode-upgrade-skip").AsAdmin() | ||
|
|
||
| // Check if feature gate is enabled | ||
| if !exutil.IsTechPreviewNoUpgrade(context.Background(), oc.AdminConfigClient()) { | ||
| e2e.Logf("Skipping: GatewayAPIManagementMode feature is not in TechPreviewNoUpgrade") | ||
| return true | ||
| } | ||
|
|
||
| skip, reason, err := shouldSkipGatewayAPITests(oc, true) // NoOLM is default/GA | ||
| if err != nil { | ||
| e2e.Logf("Failed to check Gateway API skip conditions: %v", err) | ||
| return true | ||
| } | ||
| if skip { | ||
| e2e.Logf("Skipping test: %s", reason) | ||
| return true | ||
| } | ||
|
|
||
| return false | ||
| } | ||
|
Comment on lines
+46
to
+66
There was a problem hiding this comment. 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Description: Inspect the TechPreviewNoUpgrade helper and look for other upgrade tests that gate on it.
rg -nP -C 8 'func IsTechPreviewNoUpgrade\b' test/extended/util
# Find upgrade tests (Skip(upgrades.UpgradeContext)) that also check TechPreviewNoUpgrade.
rg -nP -C 5 'IsTechPreviewNoUpgrade' --type=go -g '!vendor/**'Repository: openshift/origin Length of output: 2763 🏁 Script executed: #!/bin/bash
set -e
printf '%s\n' '--- TechPreviewNoUpgrade helper ---'
sed -n '190,225p' test/extended/util/compat_otp/clusters.go
printf '%s\n' '--- config-client TechPreviewNoUpgrade helper ---'
sed -n '2188,2225p' test/extended/util/framework.go
printf '%s\n' '--- upgrade test interface and runner ---'
rg -n -C 8 'type Test interface|func .*Skip\(|Skip\(.*UpgradeContext|Test\(\s*ctx|UpgradeContext' test/e2e test/extended --type=go -g '!vendor/**' | head -n 240
printf '%s\n' '--- relevant test lines ---'
sed -n '135,175p' test/extended/router/gatewayapi_management_mode_upgrade.go
printf '%s\n' '--- all TechPreviewNoUpgrade references outside helper definitions ---'
rg -n -C 6 'IsTechPreviewNoUpgrade' --type=go -g '!vendor/**'Repository: openshift/origin Length of output: 21941 🏁 Script executed: #!/bin/bash
set -e
printf '%s\n' '--- upgrade test contract and skip invocation ---'
rg -n -C 12 'type UpgradeTest|Skip\(.*UpgradeContext|\.Skip\(|checkUpgradeability|IsNoUpgradeFeatureSet|TechPreviewNoUpgrade|CustomNoUpgrade' test/e2e/upgrade test/extended/router --type=go
printf '%s\n' '--- upgradeability implementation ---'
sed -n '230,330p' test/e2e/upgrade/upgrade.go
printf '%s\n' '--- complete imports and Skip implementation ---'
sed -n '1,90p' test/extended/router/gatewayapi_management_mode_upgrade.go
printf '%s\n' '--- all source references, including non-Go files ---'
rg -n -C 4 'IsTechPreviewNoUpgrade|TechPreviewNoUpgrade|IsNoUpgradeFeatureSet' . -g '!vendor/**' -g '!node_modules/**'Repository: openshift/origin Length of output: 50373 🏁 Script executed: #!/bin/bash
set -e
printf '%s\n' '--- management-mode upgrade test ---'
sed -n '1,210p' test/extended/router/gatewayapi_management_mode_upgrade.go
printf '%s\n' '--- upgrade test registration ---'
rg -n -C 8 'GatewayAPIManagementModeUpgradeTest|gateway-api-mgmt-mode-upgrade' test/e2e/upgrade/upgrade.go test/extended/router/gatewayapi_management_mode_upgrade.go
printf '%s\n' '--- upgrade framework interface and skip path ---'
rg -n -C 8 'type Test interface|func .*Run|Skip\(.*UpgradeContext|test\.Skip|Setup\(ctx|Teardown\(ctx' vendor test 2>/dev/null | rg 'upgrades|UpgradeContext|Skip\(.*UpgradeContext|test/e2e/upgrade' | head -n 160
printf '%s\n' '--- feature-set upgrade restrictions ---'
rg -n -C 8 'TechPreviewNoUpgrade|CustomNoUpgrade|non-upgradeable|not.*upgrade|upgrade.*feature.?set' . -g '*.go' -g '*.md' -g '*.yaml' -g '*.yml' -g '!vendor/**' | head -n 240Repository: openshift/origin Length of output: 50372 🏁 Script executed: #!/bin/bash
set -e
printf '%s\n' '--- complete upgradeability check ---'
sed -n '234,273p' test/e2e/upgrade/upgrade.go
printf '%s\n' '--- disruption skip and execution order ---'
sed -n '165,235p' test/extended/util/disruption/disruption.go
printf '%s\n' '--- upgrade feature-set references in vendored APIs and repository code ---'
rg -n -C 5 'TechPreviewNoUpgrade|ClusterNotUpgradeable|Upgradeable.*false|not upgradeable|not upgrade' vendor/k8s.io vendor/github.com/openshift . -g '*.go' -g '*.md' 2>/dev/null | head -n 260Repository: openshift/origin Length of output: 27021 🏁 Script executed: #!/bin/bash
set -e
printf '%s\n' '--- CI jobs that combine upgrade tests and feature sets ---'
rg -n -C 5 'FEATURE_SET|TechPreviewNoUpgrade|techpreview|upgrade' ci-operator test -g '*.yaml' -g '*.yml' -g '*.json' -g '*.go' -g '*.md' 2>/dev/null | rg -C 3 'FEATURE_SET|TechPreviewNoUpgrade|techpreview|upgrade' | head -n 300
printf '%s\n' '--- upgrade suite documentation and job references ---'
rg -n -C 5 'Suite:upgrade|cluster-upgrade|openshift-tests.*upgrade|upgrade.*suite|upgrade.*job' . -g '*.md' -g '*.yaml' -g '*.yml' -g '*.json' -g '*.go' -g '!vendor/**' | head -n 240Repository: openshift/origin Length of output: 40588 Do not run this test in the real upgrade suite on 🤖 Prompt for AI Agents |
||
|
|
||
| // Setup creates Gateway resources and records initial management mode | ||
| func (t *GatewayAPIManagementModeUpgradeTest) Setup(ctx context.Context, f *e2e.Framework) { | ||
| g.By("Setting up Gateway API management mode upgrade test") | ||
|
|
||
| t.oc = exutil.NewCLIWithFramework(f).AsAdmin() | ||
| t.namespace = f.Namespace.Name | ||
|
|
||
| // Get platform capabilities | ||
| t.loadBalancerSupported, t.managedDNS = getPlatformCapabilities(t.oc) | ||
|
|
||
| g.By("Recording initial management mode before upgrade") | ||
| ingress, err := getIngressCR(ctx, t.oc) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| t.startMode = ingress.Spec.GatewayAPI.ManagementMode | ||
| if t.startMode == "" { | ||
| t.startMode = operatorv1alpha1.GatewayAPIManagementModeManaged | ||
| } | ||
| e2e.Logf("Starting with management mode: %s", t.startMode) | ||
|
|
||
| // Ensure we're in Managed mode for test setup | ||
| if t.startMode != operatorv1alpha1.GatewayAPIManagementModeManaged { | ||
| g.By("Transitioning to Managed mode for setup") | ||
| err = setManagementMode(ctx, t.oc, operatorv1alpha1.GatewayAPIManagementModeManaged) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| err = waitForManagementModeTransition(ctx, t.oc, operatorv1alpha1.GatewayAPIManagementModeManaged, 5*time.Minute) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| } | ||
|
Comment on lines
+78
to
+95
There was a problem hiding this comment. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win Restore the recorded start mode instead of forcing Managed. Setup records Use ♻️ Proposed change in Teardown- g.By("Ensuring Managed mode for cleanup")
- err := setManagementMode(ctx, t.oc, operatorv1alpha1.GatewayAPIManagementModeManaged)
+ g.By("Restoring the original management mode for cleanup")
+ restoreMode := t.startMode
+ if restoreMode == "" {
+ restoreMode = operatorv1alpha1.GatewayAPIManagementModeManaged
+ }
+ err := setManagementMode(ctx, t.oc, restoreMode)
if err != nil {
- e2e.Logf("Failed to set Managed mode during cleanup: %v", err)
+ e2e.Logf("Failed to restore management mode %s during cleanup: %v", restoreMode, err)
} else {
- _ = waitForManagementModeTransition(ctx, t.oc, operatorv1alpha1.GatewayAPIManagementModeManaged, 5*time.Minute)
+ if waitErr := waitForManagementModeTransition(ctx, t.oc, restoreMode, 5*time.Minute); waitErr != nil {
+ e2e.Logf("Management mode did not settle on %s during cleanup: %v", restoreMode, waitErr)
+ }
}Note: deleting resources requires Managed mode in some flows. If that is the case, keep Managed for the delete steps and restore Also applies to: 216-226 🤖 Prompt for AI Agents |
||
|
|
||
| g.By("Creating GatewayClass") | ||
| t.gatewayClassName = "upgrade-test-mgmt-mode" | ||
| gatewayClass := buildGatewayClass(t.gatewayClassName, "openshift.io/gateway-controller/v1") | ||
| _, err = t.oc.AdminGatewayApiClient().GatewayV1().GatewayClasses().Create(ctx, gatewayClass, metav1.CreateOptions{}) | ||
| if err != nil && !apierrors.IsAlreadyExists(err) { | ||
| e2e.Failf("Failed to create GatewayClass: %v", err) | ||
| } | ||
|
|
||
| err = checkGatewayClassCondition(t.oc, t.gatewayClassName, string(gatewayv1.GatewayClassConditionStatusAccepted), metav1.ConditionTrue) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| g.By("Creating Gateway") | ||
| defaultIngressDomain, err := getDefaultIngressClusterDomainName(t.oc, 1*time.Minute) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| customDomain := strings.Replace(defaultIngressDomain, "apps.", "gw-upgrade-mgmt.", 1) | ||
|
|
||
| t.gatewayName = "upgrade-mgmt-mode-gateway" | ||
| t.hostname = "test-upgrade-mgmt." + customDomain | ||
|
Comment on lines
+109
to
+114
There was a problem hiding this comment. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Confirm the custom domain replacement always applies.
Assert that the replacement changed the value, or derive the custom domain by prefixing the cluster base domain. 🤖 Prompt for AI Agents |
||
|
|
||
| _, err = createAndCheckGateway(t.oc, t.gatewayName, t.gatewayClassName, customDomain, t.loadBalancerSupported) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| if t.loadBalancerSupported { | ||
| g.By("Verifying LoadBalancer service is ready") | ||
| assertGatewayLoadbalancerReady(t.oc, t.gatewayName, t.gatewayName+"-openshift-default") | ||
| } | ||
|
|
||
| if t.managedDNS { | ||
| g.By("Verifying DNS controller creates DNSRecord") | ||
| assertDNSRecordStatus(t.oc, t.gatewayName) | ||
| } | ||
|
|
||
| g.By("Creating HTTPRoute with backend") | ||
| t.routeName = "test-upgrade-mgmt-route" | ||
| backendName := "echo-backend-" + t.gatewayName | ||
| createHttpRoute(t.oc, t.gatewayName, t.routeName, t.hostname, backendName) | ||
|
|
||
| g.By("Waiting for HTTPRoute to be accepted") | ||
| _, err = assertHttpRouteSuccessful(t.oc, t.gatewayName, t.routeName) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| if t.loadBalancerSupported && t.managedDNS { | ||
| g.By("Verifying HTTP connectivity before upgrade") | ||
| assertHttpRouteConnection(t.hostname) | ||
| e2e.Logf("HTTPRoute connectivity verified before upgrade") | ||
| } | ||
|
|
||
| e2e.Logf("Setup complete: Gateway and HTTPRoute created in %s mode", t.startMode) | ||
| } | ||
|
|
||
| // Test validates resources after upgrade and tests mode transitions | ||
| func (t *GatewayAPIManagementModeUpgradeTest) Test(ctx context.Context, f *e2e.Framework, done <-chan struct{}, _ upgrades.UpgradeType) { | ||
| g.By("Validating Gateway API management mode functionality after upgrade") | ||
|
|
||
| // Block until upgrade completes | ||
| g.By("Waiting for upgrade to complete") | ||
| <-done | ||
|
|
||
| g.By("Verifying Gateway still exists and is programmed") | ||
| _, err := checkGatewayStatus(t.oc, t.gatewayName, ingressNamespace, t.loadBalancerSupported) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| g.By("Verifying HTTPRoute still exists and is accepted") | ||
| _, err = assertHttpRouteSuccessful(t.oc, t.gatewayName, t.routeName) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| if t.loadBalancerSupported && t.managedDNS { | ||
| g.By("Verifying HTTP connectivity after upgrade") | ||
| assertHttpRouteConnection(t.hostname) | ||
| } | ||
|
|
||
| g.By("Checking current management mode after upgrade") | ||
| ingress, err := getIngressCR(ctx, t.oc) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| currentMode := ingress.Spec.GatewayAPI.ManagementMode | ||
| if currentMode == "" { | ||
| currentMode = operatorv1alpha1.GatewayAPIManagementModeManaged | ||
| } | ||
| e2e.Logf("Current management mode after upgrade: %s", currentMode) | ||
|
|
||
| // Test mode transitions in both directions | ||
| g.By("Testing mode transitions after upgrade") | ||
|
|
||
| // Transition 1: Current mode → Opposite mode | ||
| var targetMode1 operatorv1alpha1.GatewayAPIManagementMode | ||
| if currentMode == operatorv1alpha1.GatewayAPIManagementModeManaged { | ||
| targetMode1 = operatorv1alpha1.GatewayAPIManagementModeUnmanaged | ||
| } else { | ||
| targetMode1 = operatorv1alpha1.GatewayAPIManagementModeManaged | ||
| } | ||
|
|
||
| g.By(fmt.Sprintf("Transitioning from %s to %s", currentMode, targetMode1)) | ||
| err = setManagementMode(ctx, t.oc, targetMode1) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| err = waitForManagementModeTransition(ctx, t.oc, targetMode1, 5*time.Minute) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| t.validateModeState(ctx, targetMode1) | ||
|
|
||
| g.By("Verifying Gateway and HTTPRoute remain functional after first transition") | ||
| _, err = checkGatewayStatus(t.oc, t.gatewayName, ingressNamespace, t.loadBalancerSupported) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| _, err = assertHttpRouteSuccessful(t.oc, t.gatewayName, t.routeName) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| // Transition 2: Opposite mode → Original mode | ||
| targetMode2 := currentMode | ||
|
|
||
| g.By(fmt.Sprintf("Transitioning from %s back to %s", targetMode1, targetMode2)) | ||
| err = setManagementMode(ctx, t.oc, targetMode2) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| err = waitForManagementModeTransition(ctx, t.oc, targetMode2, 5*time.Minute) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| t.validateModeState(ctx, targetMode2) | ||
|
|
||
| g.By("Verifying Gateway and HTTPRoute remain functional after second transition") | ||
| _, err = checkGatewayStatus(t.oc, t.gatewayName, ingressNamespace, t.loadBalancerSupported) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| _, err = assertHttpRouteSuccessful(t.oc, t.gatewayName, t.routeName) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| if t.loadBalancerSupported && t.managedDNS { | ||
| g.By("Verifying HTTP connectivity still works after both transitions") | ||
| assertHttpRouteConnection(t.hostname) | ||
| } | ||
|
|
||
| // Verify DNS and controller reconciliation if in Managed mode | ||
| if targetMode2 == operatorv1alpha1.GatewayAPIManagementModeManaged { | ||
| g.By("Verifying controllers are actively reconciling in Managed mode") | ||
|
|
||
| if t.managedDNS { | ||
| g.By("Verifying DNS controller is reconciling DNSRecords") | ||
| assertDNSRecordStatus(t.oc, t.gatewayName) | ||
| } | ||
|
|
||
| g.By("Verifying gateway-status controller is updating Gateway status") | ||
| _, err = checkGatewayStatus(t.oc, t.gatewayName, ingressNamespace, t.loadBalancerSupported) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| } | ||
|
|
||
| e2e.Logf("Successfully tested management mode transitions after upgrade: %s → %s → %s", | ||
| currentMode, targetMode1, targetMode2) | ||
| } | ||
|
|
||
| // validateModeState verifies the cluster state matches the expected management mode | ||
| func (t *GatewayAPIManagementModeUpgradeTest) validateModeState(ctx context.Context, expectedMode operatorv1alpha1.GatewayAPIManagementMode) { | ||
| if expectedMode == operatorv1alpha1.GatewayAPIManagementModeManaged { | ||
| g.By("Validating Managed mode state") | ||
|
|
||
| err := checkIngressCondition(ctx, t.oc, "GatewayAPICRDsManaged", metav1.ConditionTrue, "") | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| err = assertVAPExists(ctx, t.oc, gwapiCRDVAPName) | ||
| o.Expect(err).NotTo(o.HaveOccurred(), "VAP should exist in Managed mode") | ||
|
|
||
| err = checkIstiodRunning(t.oc, 5*time.Minute) | ||
| o.Expect(err).NotTo(o.HaveOccurred(), "Istiod should be running in Managed mode") | ||
|
|
||
| e2e.Logf("Validated Managed mode state: VAP and Istiod are present") | ||
| } else { | ||
| g.By("Validating Unmanaged mode state") | ||
|
|
||
| err := checkIngressCondition(ctx, t.oc, "GatewayAPICRDsManaged", metav1.ConditionFalse, "Unmanaged") | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| err = assertVAPDeleted(ctx, t.oc, gwapiCRDVAPName) | ||
| o.Expect(err).NotTo(o.HaveOccurred(), "VAP should be deleted in Unmanaged mode") | ||
|
|
||
| waitForIstiodPodDeletion(t.oc) | ||
|
|
||
| e2e.Logf("Validated Unmanaged mode state: VAP and Istiod are removed") | ||
| } | ||
|
|
||
| // CRDs should always be present regardless of mode | ||
| g.By("Verifying Gateway API CRDs are still present") | ||
| assertGatewayAPICRDsInstalled(ctx, t.oc) | ||
| } | ||
|
|
||
| // Teardown cleans up Gateway API resources | ||
| func (t *GatewayAPIManagementModeUpgradeTest) Teardown(ctx context.Context, f *e2e.Framework) { | ||
| if t.oc == nil || t.gatewayName == "" { | ||
| e2e.Logf("Skipping cleanup because setup did not initialize resources") | ||
| return | ||
| } | ||
|
|
||
| g.By("Ensuring Managed mode for cleanup") | ||
| err := setManagementMode(ctx, t.oc, operatorv1alpha1.GatewayAPIManagementModeManaged) | ||
| if err != nil { | ||
| e2e.Logf("Failed to set Managed mode during cleanup: %v", err) | ||
| } else { | ||
| _ = waitForManagementModeTransition(ctx, t.oc, operatorv1alpha1.GatewayAPIManagementModeManaged, 5*time.Minute) | ||
| } | ||
|
|
||
| g.By("Deleting HTTPRoute") | ||
| err = t.oc.AdminGatewayApiClient().GatewayV1().HTTPRoutes(t.namespace).Delete(ctx, t.routeName, metav1.DeleteOptions{}) | ||
| if err != nil && !apierrors.IsNotFound(err) { | ||
| e2e.Logf("Failed to delete HTTPRoute: %v", err) | ||
| } | ||
|
|
||
| g.By("Deleting Gateway") | ||
| err = t.oc.AdminGatewayApiClient().GatewayV1().Gateways(ingressNamespace).Delete(ctx, t.gatewayName, metav1.DeleteOptions{}) | ||
| if err != nil && !apierrors.IsNotFound(err) { | ||
| e2e.Logf("Failed to delete Gateway: %v", err) | ||
| } | ||
|
|
||
| g.By("Waiting for Gateway deployment to be deleted") | ||
| if err := waitForGatewayDeploymentDeletion(t.oc, t.gatewayName); err != nil { | ||
| e2e.Logf("Gateway deployment was not cleaned up: %v", err) | ||
| } | ||
|
|
||
| g.By("Deleting GatewayClass") | ||
| err = t.oc.AdminGatewayApiClient().GatewayV1().GatewayClasses().Delete(ctx, t.gatewayClassName, metav1.DeleteOptions{}) | ||
| if err != nil && !apierrors.IsNotFound(err) { | ||
| e2e.Logf("Failed to delete GatewayClass: %v", err) | ||
| } | ||
|
|
||
| e2e.Logf("Gateway API management mode upgrade test cleanup complete") | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/origin
Length of output: 3019
🏁 Script executed:
Repository: openshift/origin
Length of output: 1331
🏁 Script executed:
Repository: openshift/origin
Length of output: 9410
Run
go mod tidy && go mod vendor.go.sumcontains four obsolete checksums for the previous OpenShift API and client-go versions. The vendored packages provide the requested API symbols.🤖 Prompt for AI Agents
Source: Coding guidelines