fix public-ip for node-sdn - #766
Merged
Merged
Conversation
Contributor
Author
|
[merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/708/) (Image: devenv-fedora_610) |
Contributor
|
Evaluated for origin up to 0385beb |
openshift-bot
pushed a commit
that referenced
this pull request
Jan 28, 2015
Merged by openshift-bot
sjenning
pushed a commit
to sjenning/origin
that referenced
this pull request
Jan 5, 2018
Merged by openshift-bot
weliang1
added a commit
to weliang1/origin
that referenced
this pull request
Aug 11, 2026
Remove [OCPFeatureGate:TLSAdherence] label from TLS compliance tests to fix test filtering issue in CI. The cluster-state filter was excluding these tests even when TLSAdherence was enabled, resulting in "no tests to run" errors. The test already has robust logic to automatically enable TLSAdherence feature gate if not already enabled, following the pattern from ingress-node-firewall PR openshift#766. This includes: - Checking if TLSAdherence is enabled - Enabling the feature gate if needed - Waiting for MCP rollout, node stability, and operator settlement - Verifying feature gate is active before running tests Impact: - Tests now discoverable via openshift/conformance/serial suite - All 3 test cases (Modern+Legacy, Modern+Strict, Intermediate+Strict) now appear in test discovery - CI will successfully run tests without manual feature gate setup Before: cluster-state filter removed test (0 tests to run) After: All 3 tests kept and assigned to serial conformance suite Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
weliang1
added a commit
to weliang1/origin
that referenced
this pull request
Aug 11, 2026
…irewall PR openshift#766 Add missing MCP rollout handling functions to make test more robust when enabling feature gates and applying TLS profile configurations. Following the proven pattern from openshift/ingress-node-firewall PR openshift#766. New functions: - waitForMCPRolloutStart(): Waits for MCP "Updating" condition before checking completion, avoiding race where we check status before rollout begins - areAllMCPsComplete(): Checks if MCPs are already stable before waiting, avoiding unnecessary waits Flow improvements: 1. After enabling TLSAdherence feature gate: - Wait for MCP rollout to START (10 min timeout) - If started, wait for completion (60 min timeout) - Prevents false positives from checking before rollout begins 2. After applying TLS profile configuration: - Check if MCPs are already complete - If not complete, wait for rollout start then completion - Avoids redundant waits when MCPs are already stable This eliminates race conditions where we might check MCP status too early before the rollout has begun, leading to false positives. Reference: openshift/ingress-node-firewall#766 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.