Skip to content

NO-JIRA: More prep patches for split rhel-coreos-base#1503

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
jlebon:pr/c9s-split-prep3
May 8, 2024
Merged

NO-JIRA: More prep patches for split rhel-coreos-base#1503
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
jlebon:pr/c9s-split-prep3

Conversation

@jlebon

@jlebon jlebon commented May 6, 2024

Copy link
Copy Markdown
Member

This is prep for #1445, which I'm working on updating soon.

jlebon added 2 commits May 6, 2024 17:07
This is a brutal hack for working around `usermod` not being NSS-aware.
This is the same bug as coreos/rpm-ostree#1318
but in the container flow.
The MOTD message is strongly associated with OpenShift, so let's make it
part of `packages-openshift.yaml`.

Note here that the postprocess script in `packages-openshift.yaml` is
run *before* the ones in the parent manifests, which is why they have
access to e.g. `OPENSHIFT_VERSION`.
@openshift-ci openshift-ci Bot requested review from prestist and yasminvalim May 6, 2024 21:10
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024

@jbtrystram jbtrystram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travier travier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@travier

travier commented May 7, 2024

Copy link
Copy Markdown
Member

/retest

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci

openshift-ci Bot commented May 7, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbtrystram, jlebon, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jbtrystram,jlebon,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier

travier commented May 7, 2024

Copy link
Copy Markdown
Member

CI is broken pending openshift/release#51750

@jlebon

jlebon commented May 7, 2024

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@jlebon

jlebon commented May 8, 2024

Copy link
Copy Markdown
Member Author

/retest

@jlebon jlebon changed the title More prep patches for split rhel-coreos-base NO-JIRA: More prep patches for split rhel-coreos-base May 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2024
@openshift-ci-robot

Copy link
Copy Markdown

@jlebon: This pull request explicitly references no jira issue.

Details

In response to this:

This is prep for #1445, which I'm working on updating soon.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented May 8, 2024

Copy link
Copy Markdown
Contributor

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit c1efdbd into openshift:master May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants