openstack-test: migrate CI config to OTE (openshift-tests-extension)#79487
openstack-test: migrate CI config to OTE (openshift-tests-extension)#79487mandre wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
WalkthroughThis pull request introduces a new ChangesOpenStack OTE Step Registry Integration
🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/openstack-test/openshift-openstack-test-main.yaml`:
- Around line 1-2: The current binary_build_commands creates a tarball instead
of delivering the executable expected by OTE; update the build step referenced
by binary_build_commands so the actual Go binary (openstack-test-tests-ext) ends
up in /usr/bin/ — either extract the tarball and copy the extracted binary into
/usr/bin/ or skip tarball creation and copy bin/openstack-test-tests-ext
directly to /usr/bin/ after running make tests-ext-build.
In
`@ci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-commands.sh`:
- Line 49: The script line that pipes TESTS into grep and assigns exit_code uses
"return $exit_code" which is invalid outside a function; change that final
"return $exit_code" to "exit $exit_code" so the script terminates properly when
no tests match OPENSTACK_TEST_SKIPS (the line referencing TESTS,
OPENSTACK_TEST_SKIPS and exit_code).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 4b31c67c-254c-476e-87de-b50a6f7db460
📒 Files selected for processing (5)
ci-operator/config/openshift/openstack-test/openshift-openstack-test-main.yamlci-operator/step-registry/openstack/test/openstack-ote/OWNERSci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-commands.shci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-ref.metadata.jsonci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-ref.yaml
|
We need to apply the same change to all workflows on main and 4.23+ branches. |
openshift-ci
Bot
added
the
do-not-merge/hold
mandre
force-pushed
the
openstack-test-ote
branch
from
cc98bdd to
3844659
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/config/openshift/openstack-test/openshift-openstack-test-main.yaml (1)
1-85:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRegenerate CI artifacts for this config change.
This is a structural
ci-operator/configupdate (test refs/workflow behavior), so please runmake updateand include generated downstream changes if any.As per coding guidelines: “After modifying CI configuration files in
ci-operator/config/, regenerate downstream artifacts by runningmake update”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/openstack-test/openshift-openstack-test-main.yaml` around lines 1 - 85, You changed CI configuration (test refs like openstack-test-openstack-ote and workflows openshift-e2e-openstack-ipi / openshift-e2e-openstack-dualstack) under ci-operator/config, so run the repository's codegen to regenerate downstream CI artifacts by executing make update, then add and commit all generated changes (the downstream files that make update modifies) to this PR so the updated artifacts accompany your config change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-commands.sh`:
- Around line 40-41: The oc RBAC grant command (oc adm policy add-role-to-group
system:image-puller system:unauthenticated --namespace "${NAMESPACE}") must not
be downgraded to a warning; change the line so failures are detected and the job
fails fast — remove the trailing "|| echo ..." and instead check the command's
exit status and abort (e.g., if the oc command returns non-zero, print an error
to stderr referencing "${NAMESPACE}" and exit 1) before exporting KUBECONFIG,
ensuring the required setup step fails the run immediately.
---
Outside diff comments:
In
`@ci-operator/config/openshift/openstack-test/openshift-openstack-test-main.yaml`:
- Around line 1-85: You changed CI configuration (test refs like
openstack-test-openstack-ote and workflows openshift-e2e-openstack-ipi /
openshift-e2e-openstack-dualstack) under ci-operator/config, so run the
repository's codegen to regenerate downstream CI artifacts by executing make
update, then add and commit all generated changes (the downstream files that
make update modifies) to this PR so the updated artifacts accompany your config
change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 06c5dc79-b579-4826-a5b6-8d90a48df187
📒 Files selected for processing (6)
ci-operator/config/openshift/openstack-test/openshift-openstack-test-main.yamlci-operator/step-registry/openstack/test/openstack-ote/OWNERSci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-commands.shci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-ref.metadata.jsonci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-ref.yamlci-operator/step-registry/openstack/test/openstack/openstack-test-openstack-commands.sh
✅ Files skipped from review due to trivial changes (2)
- ci-operator/step-registry/openstack/test/openstack-ote/OWNERS
- ci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-ref.metadata.json
| oc adm policy add-role-to-group system:image-puller system:unauthenticated --namespace "${NAMESPACE}" || echo "Warning: Failed to grant image puller access, continuing..." | ||
| export KUBECONFIG=$KUBECONFIG_BAK |
There was a problem hiding this comment.
Fail fast when the image-puller RBAC grant fails.
Line 40 downgrades a required setup step to a warning, which can hide the root cause and surface later as opaque test failures.
Suggested fix
-oc adm policy add-role-to-group system:image-puller system:unauthenticated --namespace "${NAMESPACE}" || echo "Warning: Failed to grant image puller access, continuing..."
+oc adm policy add-role-to-group system:image-puller system:unauthenticated --namespace "${NAMESPACE}"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-commands.sh`
around lines 40 - 41, The oc RBAC grant command (oc adm policy add-role-to-group
system:image-puller system:unauthenticated --namespace "${NAMESPACE}") must not
be downgraded to a warning; change the line so failures are detected and the job
fails fast — remove the trailing "|| echo ..." and instead check the command's
exit status and abort (e.g., if the oc command returns non-zero, print an error
to stderr referencing "${NAMESPACE}" and exit 1) before exporting KUBECONFIG,
ensuring the required setup step fails the run immediately.
|
@mandre: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse pull-ci-openshift-openstack-test-main-build |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-main-test |
1 similar comment
|
/pj-rehearse pull-ci-openshift-openstack-test-main-test |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mandre, |
Update the openstack-test main CI configuration to support the OTE migration in openshift/openstack-test#260. Changes: - binary_build_commands: build OTE extension binary via 'make tests-ext-build', package as tar.gz, and place at /usr/bin/ for payload discovery by openshift-tests - build test: verify the extension binary with --help instead of the removed openstack-tests binary - test/ccpmso jobs: use new openstack-test-openstack-ote step ref - dualstack jobs: override test phase with openshift-e2e-test + openstack-test-openstack-ote (replacing the old chain that used openstack-test-openstack) New step registry ref openstack-test-openstack-ote: - Runs from 'tests' image (openshift-tests) instead of 'openstack-tests' - Discovers the openstack-test extension from the release payload - Grants image-puller access for extension discovery - Supports same env vars: OS_CLOUD, OPENSTACK_TEST_SKIPS, CONFIG_TYPE - Runs 'openshift-tests run openstack-test/all' suite The old openstack-test-openstack step ref is preserved for older release branches that still use the standalone openstack-tests binary.
mandre
force-pushed
the
openstack-test-ote
branch
from
3844659 to
da8e8d0
Compare
|
/pj-rehearse pull-ci-openshift-openstack-test-main-test |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 932 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-openstack-test-main-build |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-main-images |
|
/pj-rehearse pull-ci-openshift-openstack-test-main-verify |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/openstack-test/openshift-openstack-test-main.yaml`:
- Line 1: The ci-operator config change modified the binary_build_commands entry
(the line containing "binary_build_commands: make tests-ext-build && cp
bin/openstack-test-tests-ext /usr/bin/") and requires regenerating downstream CI
artifacts; run make update at the repo root, review and add the generated
changes (including updates for the other affected sections referenced: lines
around 44-45, 64-65, 71-74, 82-85), verify the generated files pass CI, and
commit the regenerated artifacts alongside this config change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: cbcd4dd3-6376-40d6-92cf-181cfc53b0a8
📒 Files selected for processing (6)
ci-operator/config/openshift/openstack-test/openshift-openstack-test-main.yamlci-operator/step-registry/openstack/test/openstack-ote/OWNERSci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-commands.shci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-ref.metadata.jsonci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-ref.yamlci-operator/step-registry/openstack/test/openstack/openstack-test-openstack-commands.sh
✅ Files skipped from review due to trivial changes (2)
- ci-operator/step-registry/openstack/test/openstack-ote/OWNERS
- ci-operator/step-registry/openstack/test/openstack-ote/openstack-test-openstack-ote-ref.metadata.json
| @@ -1,4 +1,4 @@ | |||
| binary_build_commands: go build -o /bin/openstack-tests ./cmd/openshift-tests | |||
| binary_build_commands: make tests-ext-build && cp bin/openstack-test-tests-ext /usr/bin/ | |||
There was a problem hiding this comment.
Regenerate CI artifacts after this ci-operator config change.
This file has structural CI test-step wiring changes, so please run make update and include downstream generated updates if any.
As per coding guidelines, "After modifying CI configuration files in ci-operator/config/, regenerate downstream artifacts by running make update".
Also applies to: 44-45, 64-65, 71-74, 82-85
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/openstack-test/openshift-openstack-test-main.yaml`
at line 1, The ci-operator config change modified the binary_build_commands
entry (the line containing "binary_build_commands: make tests-ext-build && cp
bin/openstack-test-tests-ext /usr/bin/") and requires regenerating downstream CI
artifacts; run make update at the repo root, review and add the generated
changes (including updates for the other affected sections referenced: lines
around 44-45, 64-65, 71-74, 82-85), verify the generated files pass CI, and
commit the regenerated artifacts alongside this config change.
1 participant
Update the openstack-test main CI configuration to support the OTE migration in openshift/openstack-test#260.
Changes:
New step registry ref openstack-test-openstack-ote:
The old openstack-test-openstack step ref is preserved for older release branches that still use the standalone openstack-tests binary.
OpenStack Test CI Migration to OTE (OpenShift Tests Extension)
This PR updates the OpenShift CI configuration in the openshift/release repository for the openstack-test component on main to build and run the OpenShift Tests Extension (OTE) via openshift-tests instead of the legacy openstack-tests binary. It changes build, discovery, and test execution so the openstack-test extension is discovered from the release payload and executed by openshift-tests.
What changed in practical terms
Other script change noted
Net effect