OCM-25174 | add: Backup jobs for all backup tests#79623
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughFive periodic ROSA HCP integration test job entries are added to the CI YAML. Each runs daily at 08:00 in a nested-podman container, mounts shared credentials, sets up Jira reporting env/job-link, and invokes ChangesROSA HCP Periodic Integration Tests
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elveeram The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml (2)
70-70: 💤 Low valueNaming inconsistency:
-int-mainvs existing-integration-mainsuffix.The pre-existing entry on Line 25 uses
…-integration-mainin itsas:name, whereas the five new entries use the abbreviated…-int-main. Consider aligning on a single convention for discoverability and consistency in dashboards/test grids.Also applies to: 115-115, 160-160, 205-205, 250-250
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml` at line 70, The as: names use an inconsistent suffix (e.g., ocm-fvt-periodic-cs-rosa-hcp-autoscaling-int-main) compared to the existing convention (ocm-fvt-periodic-cs-rosa-hcp-autoscaling-integration-main); update all five new as: entries (the ones ending with -int-main) to use the full -integration-main suffix so they match the existing as: identifier and remain discoverable/consistent in dashboards and test grids.
65-65: 💤 Low valueConsider staggering cron schedules to avoid load spike.
All six periodic jobs (existing + five new) fire at exactly
0 8 * * *, kicking off six concurrent nested-podman runs that each pullquay.io/redhat-services-prod/ocmci/ocmci:latestand hit the same CMS integration backend. Staggering minutes (e.g.,0 8 * * *,15 8 * * *,30 8 * * *, …) would smooth registry/integration load and reduce contention on shared credentials/quotas.Also applies to: 110-110, 155-155, 200-200, 245-245, 290-290
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml` at line 65, Multiple periodic jobs all use the identical schedule "cron: 0 8 * * *", causing concurrent runs; update each job's cron field (the "cron:" entries currently set to "0 8 * * *") so the six periodic jobs are staggered across the hour (e.g., 0, 15, 30, 45, 05, 20 minutes) to avoid simultaneous pulls and backend load—apply this change to every occurrence of the "cron: 0 8 * * *" entry referenced (the other occurrences noted in the review).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml`:
- Around line 70-294: New CI config added multiple jobs (examples: as:
ocm-fvt-periodic-cs-rosa-hcp-autoscaling-int-main,
ocm-fvt-periodic-cs-rosa-hcp-backup-autoscaling-2-int-main,
ocm-fvt-periodic-cs-rosa-hcp-backup-cp-upgrade-2-int-main, etc.) but the
generated ProwJob artifacts in ci-operator/jobs/ were not updated; run make
update to regenerate downstream ProwJob YAMLs and commit the updated artifacts
alongside this config change so the new "as:" entries are reflected in
ci-operator/jobs/.
- Around line 70-114: The PR title/description and the job in this config are
inconsistent: the config defines
ocm-fvt-periodic-cs-rosa-hcp-autoscaling-int-main and runs ocmtest with --job
cs-rosa-hcp-autoscaling-integration-main (an autoscaling test) while the PR is
titled “Backup jobs for all backup tests”; either update the PR
title/description to reflect that this change adds the autoscaling periodic job,
or modify the job/config to actually add the intended backup job; also ensure
any duplicate-check logic includes cs-rosa-hcp-autoscaling-integration-main (or
hcp-autoscaling-int-main) if you intended to prevent duplicates across the repo
so the autoscaling entry isn’t falsely flagged/missed.
---
Nitpick comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml`:
- Line 70: The as: names use an inconsistent suffix (e.g.,
ocm-fvt-periodic-cs-rosa-hcp-autoscaling-int-main) compared to the existing
convention (ocm-fvt-periodic-cs-rosa-hcp-autoscaling-integration-main); update
all five new as: entries (the ones ending with -int-main) to use the full
-integration-main suffix so they match the existing as: identifier and remain
discoverable/consistent in dashboards and test grids.
- Line 65: Multiple periodic jobs all use the identical schedule "cron: 0 8 * *
*", causing concurrent runs; update each job's cron field (the "cron:" entries
currently set to "0 8 * * *") so the six periodic jobs are staggered across the
hour (e.g., 0, 15, 30, 45, 05, 20 minutes) to avoid simultaneous pulls and
backend load—apply this change to every occurrence of the "cron: 0 8 * * *"
entry referenced (the other occurrences noted in the review).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 97d114cd-93b0-41a1-87b7-e28d4ef18b05
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml
|
/retest |
1 similar comment
|
/retest |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-autoscaling-int-main |
|
@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@elveeram: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Generated 5 new jobs for all backup tests.
Summary by CodeRabbit
This PR updates the OpenShift CI configuration for ROSA (openshift-online/rosa-e2e) by adding five new periodic ROSA HCP integration test jobs focused on backup and autoscaling scenarios.
What changed (practical impact):
How the jobs run:
Impact: