USHIFT-7116: add microshift-release-evaluation periodic job#79994
USHIFT-7116: add microshift-release-evaluation periodic job#79994agullon wants to merge 3 commits into
Conversation
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a scheduled CI job and step-registry to run a Claude-driven MicroShift release pre-check (Thursdays/Fridays 16:00 UTC), including workflow/ref/metadata/OWNERS entries and a Bash orchestration script that loads secrets, configures Claude/MCPs, runs the pre-check, and saves results for the Slack reporter. ChangesMicroShift Release Evaluation Workflow
Sequence DiagramsequenceDiagram
participant Prow as Prow
participant Job as CI Job
participant Script as evaluation script
participant GitHub as GitHub (repo/token)
participant Claude as Claude
participant Jira as Jira (optional)
participant Artifacts as ArtifactDir
participant Reporter as Prow Reporter (Slack)
Prow->>Job: trigger scheduled job
Job->>Script: execute evaluation commands
Script->>GitHub: obtain repo (clone/fetch) and token
Script->>Claude: configure MCPs and send pre-check prompt
Claude->>Jira: optional MCP connection (if creds present)
Claude->>Script: stream-json pre-check results
Script->>Artifacts: write precheck-results.txt, claude-precheck.log
Job->>Reporter: report success/failure using artifacts
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested labels
Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@agullon: This pull request references USHIFT-7116 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/openshift/edge-tooling/microshift-release/evaluation/openshift-edge-tooling-microshift-release-evaluation-commands.sh`:
- Around line 2-3: The script currently enables bash xtrace globally via the
"set -x" invocation; remove that global "set -x" so the script starts with only
"set -euo pipefail" and never leaves tracing on for the whole step, and if debug
output is needed wrap the minimal sensitive sections with scoped tracing blocks
using "set -x" immediately before the debug lines and "set +x" right after
(refer to the existing "set -euo pipefail" and "set -x" entries to locate and
change this).
- Around line 37-45: The fallback that extracts Claude output writes results
only to ${SHARED_DIR} (variables result_text, CLAUDE_LOG, and files
precheck-results.txt / precheck-completed) but not to the artifact location,
breaking the advertised artifacts link; update the branch that handles
result_text to also persist the same files into ${ARTIFACT_DIR} (write
${ARTIFACT_DIR}/precheck-results.txt and touch
${ARTIFACT_DIR}/precheck-completed) so both SHARED_DIR and ARTIFACT_DIR contain
the fallback outputs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 29c69d3e-f50f-40d0-9554-5b0b41f19781
📒 Files selected for processing (7)
ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yamlci-operator/step-registry/openshift/edge-tooling/microshift-release/evaluation/OWNERSci-operator/step-registry/openshift/edge-tooling/microshift-release/evaluation/openshift-edge-tooling-microshift-release-evaluation-commands.shci-operator/step-registry/openshift/edge-tooling/microshift-release/evaluation/openshift-edge-tooling-microshift-release-evaluation-ref.metadata.jsonci-operator/step-registry/openshift/edge-tooling/microshift-release/evaluation/openshift-edge-tooling-microshift-release-evaluation-ref.yamlci-operator/step-registry/openshift/edge-tooling/microshift-release/evaluation/openshift-edge-tooling-microshift-release-evaluation-workflow.metadata.jsonci-operator/step-registry/openshift/edge-tooling/microshift-release/evaluation/openshift-edge-tooling-microshift-release-evaluation-workflow.yaml
Accepted after review: - commands.sh:42: Persist fallback results to ARTIFACT_DIR Co-Authored-By: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> pre-commit.check-secrets: ENABLED
|
@agullon, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Persist fallback results to ARTIFACT_DIR in addition to SHARED_DIR. When RESULTS_TEXT file doesn't exist but results can be extracted from Claude log, they were only written to SHARED_DIR. This breaks the Slack artifact link which points to ARTIFACT_DIR. Co-Authored-By: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> pre-commit.check-secrets: ENABLED
|
/label tide/merge-method-squash |
|
/hold cancel |
Persist fallback results to ARTIFACT_DIR in addition to SHARED_DIR. When RESULTS_TEXT file doesn't exist but results can be extracted from Claude log, they were only written to SHARED_DIR. This breaks the Slack artifact link which points to ARTIFACT_DIR. Co-Authored-By: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> pre-commit.check-secrets: ENABLED
|
@agullon, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/test prow-config-filenames |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-release-evaluation |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@agullon: job(s): periodic-ci-openshift-eng-edge-tooling-main-microshift-release-evaluation either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-release-evaluation |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@agullon: job(s): periodic-ci-openshift-eng-edge-tooling-main-microshift-release-evaluation either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-release-evaluation |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
afb6b04 to
5ea7f02
Compare
Add workflow, ref, and commands script for the MicroShift release evaluation periodic job. Uses Claude AI to query ART Jira for upcoming OCP z-stream releases and evaluate MicroShift participation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
…116) Add periodic job running every Thursday and Friday at 16:00 UTC. Slack notifications to #team-ocp-edge-notifications on completion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-release-evaluation |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
The skill invokes git, python3, and mkdir commands that require explicit permissions in CI. The Skill(...) permission only covers invoking the skill itself, not the tools it uses internally. Added permissions for: - git operations (rev-parse, fetch, clone, sparse-checkout, branch, log) - python3 venv operations (venv creation, pip install) - mkdir for output directories All permissions are read-only or create isolated artifacts in /tmp. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-release-evaluation |
|
@agullon: |
|
@agullon: your |
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-release-evaluation |
|
@agullon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@agullon: your |
|
@openshift-ci[bot]: your |
|
@openshift-merge-bot[bot]: your |
Summary
Adds a new Prow periodic job (
microshift-release-evaluation) that automates MicroShift release evaluation for upcoming OCP z-stream releases.microshift-release:pre-checkAI skill every Thursday and Friday at 16:00 UTC#team-ocp-edge-notificationsvia Prowreporter_configmicroshift-ci-doctorrestrict_network_access: false) for Brew/advisory checksNew files
openshift/edge-tooling/microshift-release/evaluation/openshift-eng-edge-tooling-main.yamlBlocked by
This job depends on the edge-tooling AI helpers image containing the latest pre-check skill changes:
Jira
USHIFT-7116 (parent: USHIFT-6766)
Test plan
Summary by CodeRabbit
What changed
Practical effects
#team-ocp-edge-notificationsand includes links to the precheck-results.txt artifact and job logs.Ownership
Files added/updated (impact summary)
Security & secrets
Tests / rollout
Blockers / notes