Skip to content

NO-JIRA: fix: small format update to prow message#80055

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
eggfoobar:upkeep-microshift-ci-doctor-format
Jun 4, 2026
Merged

NO-JIRA: fix: small format update to prow message#80055
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
eggfoobar:upkeep-microshift-ci-doctor-format

Conversation

@eggfoobar

@eggfoobar eggfoobar commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR updates the OpenShift CI configuration for the openshift-eng/edge-tooling repository by adjusting the microshift-ci-doctor job's notification/report template in ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml. The change replaces three hard-coded Markdown artifact link rows with Go template logic that computes a shared base URL, defines small helper templates for the report/bugs/PR links, and emits those links using a short loop with conditional pipe separators. No other job behavior, schedules, reporter settings, or CI steps are modified.

This is a configuration-only change (YAML) and does not affect application code or exported/public APIs.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@eggfoobar: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from eslutsky and kasturinarra June 3, 2026 17:48
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9a4f9f14-5677-4df8-8d11-7edc43191de7

📥 Commits

Reviewing files that changed from the base of the PR and between 590f857 and 58d96f0.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml

Walkthrough

Replaces three hardcoded markdown link rows in the microshift-ci-doctor job's report_template with Go-template logic that computes a shared $base URL, defines helper templates for each link, and emits the three links via a range with conditional pipe separators. No other job config or steps changed.

Changes

Report template rendering

Layer / File(s) Summary
Compute base and helper templates; range-based link output
ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml
The report_template now computes a shared $base artifacts URL, defines small helper templates for the report/bugs/PR links, and uses a range with conditional selection to emit the three link segments separated by consistent `

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • openshift/release#79951: Modifies the same microshift-ci-doctor job's report_template in openshift-eng-edge-tooling-main.yaml, reformatting artifact link rendering in the CI Doctor output.

Suggested labels

lgtm

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: a small format update to a prow message in the microshift-ci-doctor job configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The check for stable/deterministic Ginkgo test names is not applicable: this PR only modifies CI configuration YAML and standard Go tests (using testing package), not Ginkgo tests.
Test Structure And Quality ✅ Passed PR modifies only CI/CD YAML configuration (report_template in microshift-ci-doctor job); no Ginkgo test code present or modified, making check inapplicable.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests were added in this PR; only Prow CI job configuration (YAML) was modified. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only YAML CI configuration (prow job template), not Ginkgo e2e tests. The check applies exclusively to new Go test code; therefore it does not apply here.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only a Prow CI job configuration file's message template; no deployment manifests, operator code, controllers, or scheduling constraints are changed.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI config file; no OTE binary code, test code, or process-level stdout writes present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only a YAML CI config file; no Ginkgo e2e tests are added. Custom check requires testing new e2e tests for IPv6/disconnected compatibility, which is not applicable.
No-Weak-Crypto ✅ Passed PR contains only YAML CI configuration updates with Go-template logic for formatting job report messages. No weak crypto, custom implementations, or insecure secret comparisons detected.
Container-Privileges ✅ Passed Changes only modify Go template formatting in prow report messages. No privileged container configs, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings present.
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data introduced in logs. Template contains only standard CI infrastructure URLs and job/build identifiers used in normal reporting.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2026
@eggfoobar eggfoobar force-pushed the upkeep-microshift-ci-doctor-format branch from 590f857 to e847940 Compare June 3, 2026 18:14
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar eggfoobar force-pushed the upkeep-microshift-ci-doctor-format branch from e847940 to 58d96f0 Compare June 3, 2026 18:37
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@eggfoobar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@eggfoobar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 3, 2026
@ggiguash

ggiguash commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2026
@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit c15f301 into openshift:main Jun 4, 2026
16 checks passed
fracappa pushed a commit to fracappa/release that referenced this pull request Jun 4, 2026
Signed-off-by: ehila <ehila@redhat.com>
TimurMP pushed a commit to TimurMP/release that referenced this pull request Jun 4, 2026
Signed-off-by: ehila <ehila@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants