Skip to content

OCPBUGS-86011: 4.22 monitoring-plugin tests#3932

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
PeterYurkovich:update-monitoring-tests
May 18, 2026
Merged

OCPBUGS-86011: 4.22 monitoring-plugin tests#3932
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
PeterYurkovich:update-monitoring-tests

Conversation

@PeterYurkovich
Copy link
Copy Markdown
Contributor

This PR looks to update the 4.22 monitoring_alerts.xyaml and monitoring_metrics.xyaml files with the dom structure for 4.22. Because all OCP versions run off of the same feature files (alerts-browser.feature and query-browser.feature), we cannot change the top level automation definitions within the file without forking the test for specifically the 4.22 tag. Due to the upcoming work in OU-1090, I do not believe it would be needed to do so for potentially only 1-2 releases, and instead the new set of tests with independent tags should be created for the above feature.

To circumvent this restriction we have used the if_param to create switch statements to path the actions and selectors into the correct directions for the new dom layout, which removes a more overarching filters menu for a combined patternfly dataview approach:

Monitoring Plugin UI Comparison

OCP of 4.21 or less

Screenshot From 2026-05-15 08-16-59

OCP of 4.22 or greater

Screenshot From 2026-05-15 08-18-15 Screenshot From 2026-05-15 08-18-34

A timeout is added in style.xyaml due to prometheus not picking up metrics for a new pod quick enough and then the charts not being rendered.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 18, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@PeterYurkovich: This pull request references Jira Issue OCPBUGS-86011, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR looks to update the 4.22 monitoring_alerts.xyaml and monitoring_metrics.xyaml files with the dom structure for 4.22. Because all OCP versions run off of the same feature files (alerts-browser.feature and query-browser.feature), we cannot change the top level automation definitions within the file without forking the test for specifically the 4.22 tag. Due to the upcoming work in OU-1090, I do not believe it would be needed to do so for potentially only 1-2 releases, and instead the new set of tests with independent tags should be created for the above feature.

To circumvent this restriction we have used the if_param to create switch statements to path the actions and selectors into the correct directions for the new dom layout, which removes a more overarching filters menu for a combined patternfly dataview approach:

Monitoring Plugin UI Comparison

OCP of 4.21 or less

Screenshot From 2026-05-15 08-16-59

OCP of 4.22 or greater

Screenshot From 2026-05-15 08-18-15 Screenshot From 2026-05-15 08-18-34

A timeout is added in style.xyaml due to prometheus not picking up metrics for a new pod quick enough and then the charts not being rendered.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from dis016 and pruan-rht May 18, 2026 02:57
@PeterYurkovich
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@PeterYurkovich: This pull request references Jira Issue OCPBUGS-86011, which is invalid:

  • expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

@PeterYurkovich: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pruan-rht
Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pruan-rht

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2026
@PeterYurkovich
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 18, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@PeterYurkovich: This pull request references Jira Issue OCPBUGS-86011, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit b683fff into openshift:main May 18, 2026
2 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@PeterYurkovich: Jira Issue OCPBUGS-86011: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-86011 has been moved to the MODIFIED state.

Details

In response to this:

This PR looks to update the 4.22 monitoring_alerts.xyaml and monitoring_metrics.xyaml files with the dom structure for 4.22. Because all OCP versions run off of the same feature files (alerts-browser.feature and query-browser.feature), we cannot change the top level automation definitions within the file without forking the test for specifically the 4.22 tag. Due to the upcoming work in OU-1090, I do not believe it would be needed to do so for potentially only 1-2 releases, and instead the new set of tests with independent tags should be created for the above feature.

To circumvent this restriction we have used the if_param to create switch statements to path the actions and selectors into the correct directions for the new dom layout, which removes a more overarching filters menu for a combined patternfly dataview approach:

Monitoring Plugin UI Comparison

OCP of 4.21 or less

Screenshot From 2026-05-15 08-16-59

OCP of 4.22 or greater

Screenshot From 2026-05-15 08-18-15 Screenshot From 2026-05-15 08-18-34

A timeout is added in style.xyaml due to prometheus not picking up metrics for a new pod quick enough and then the charts not being rendered.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants