[WYSIWYG] TinyMCEのiframe埋め込みセキュリティ設定を追加しました#2219
Merged
Merged
Conversation
Contributor
Author
|
@gakigaki レビューお願いします。 |
gakigaki
requested changes
Jul 2, 2025
gakigaki
left a comment
gakigaki
left a comment
Contributor
There was a problem hiding this comment.
ご対応ありがとうございます。ホワイトリストにGoogleの追加を検討していただければと思います。
| 'vimeo.com', | ||
| 'player.vimeo.com', | ||
| 'dailymotion.com', | ||
| 'embed.music.apple.com', |
Contributor
There was a problem hiding this comment.
GoogleMapを埋め込むことがあるかと思うので、google.comを追加されてはいかがでしょうか？アルファベット順に並んでいるので、embed.music.apple.comの下に。
Contributor
Author
There was a problem hiding this comment.
@gakigaki 指摘ありがとうございます。
動作確認ミスってて正常に動作しているものと勘違いしておりました。
Contributor
|
ご対応ありがとうございました！ |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
WYSIWYGエディタ（TinyMCE）でのiframe埋め込み機能のセキュリティ設定を改善しました。
変更内容
sandbox_iframes: trueを設定し、iframeのサンドボックス機能を有効化sandbox_iframes_exclusionsでホワイトリストを設定し、以下の外部サービスからの埋め込みを許可：目的
セキュリティを向上させながら、主要な動画・音楽配信サービスのコンテンツ埋め込みを可能にする
レビュー完了希望日
超特急
関連PR/Issues
なし
参考情報
DB変更の有無
チェックリスト