use proper initialization NULL for CORS variable, not an empty string#479
Merged
hummeltech merged 1 commit intoopenstreetmap:masterfrom Apr 14, 2025
stoecker:master
Merged
use proper initialization NULL for CORS variable, not an empty string#479hummeltech merged 1 commit intoopenstreetmap:masterfrom stoecker:master
hummeltech merged 1 commit intoopenstreetmap:masterfrom
stoecker:master
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
===========================================
- Coverage 81.54% 64.73% -16.81%
===========================================
Files 24 24
Lines 5645 4676 -969
===========================================
- Hits 4603 3027 -1576
- Misses 1042 1649 +607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Great find, thanks for the fix! |
hummeltech
added a commit
that referenced
this pull request
Apr 15, 2025
datendelphin
pushed a commit
to fossgis-routing-server/ansible_openstreetmap.de
that referenced
this pull request
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The empty string as initialization for CORS breaks the tile access in case Origin header is sent. Properly initialize it with the correct value NULL. Error was introduced 10 months ago it seems.