chore(docs): restructure Discovery page and add Architecture Response Objects#283
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDocumentation updates to SDK reference pages: added a standardized Setup section with Go/Java/JavaScript client initialization, restructured several discovery method docs with explicit signatures/params/returns, and added a "Response Objects" guide with language-specific examples for reading protobuf responses. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
485881b to
647c34f
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the SDK documentation for Discovery and Platform Client by adding a centralized setup section, detailed method signatures, and a guide for handling protobuf response objects across Go, Java, and JavaScript. The review feedback identifies opportunities to improve language neutrality in documentation tables, maintain variable name consistency in JavaScript examples, and correct return type descriptions for JavaScript-specific calls.
|
📄 Preview deployed to https://opentdf-docs-pr-283.surge.sh |
7748d8c to
1bcaaad
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/sdks/discovery.mdx`:
- Around line 492-506: Update the parameters docs to explicitly document the JS
request shape: mention that the JS SDK does not expose getEntityAttributes and
that callers should use PlatformClient.getEntitlements with an object payload
containing entityIdentifier; add a JS-specific parameter note or new table row
describing the expected key name (entityIdentifier) and its accepted values
(email, username, client ID, UUID) and reference PlatformClient.getEntitlements
and getEntityAttributes to avoid confusion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b08994e1-1218-4e83-9d31-3788da7afa5b
📒 Files selected for processing (2)
docs/sdks/discovery.mdxdocs/sdks/platform-client.mdx
… Objects (#274) Discovery: - Add Setup section with client init for Go, Java, JS - Add Signature/Parameters/Returns to all 5 methods - Strip inline JS auth setup from examples - Link Returns to Policy type references Architecture: - Add Response Objects section showing getter patterns across Go/Java/JS with four examples: GetAttributeValue, ListAttributeValues, GetDecision, GetEntitlements Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Consistent naming with the Authorization page. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Use language-neutral "list of strings" instead of Go-specific []string - Fix platformClient → platform variable name in GetEntityAttributes signature - Clarify that JS returns EntityEntitlements, not plain FQN strings Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
All four examples already had Go/Java/JS — now wrapped in Tabs components so the language selector is visible. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Better reflects the page content — SDK structure, client setup, and response patterns rather than system architecture. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JS uses getEntitlements with EntityIdentifier, not the same entity parameter as Go/Java. Add a note linking to the EntityIdentifier docs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
48e117a to
4ee7581
Compare
Summary
Discovery Page
Architecture Page
Part of #274
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation